https://bugzilla.redhat.com/show_bug.cgi?id=1117492 Jon Disnard <jdisnard@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Flags|fedora-review? |fedora-review+ --- Comment #8 from Jon Disnard <jdisnard@xxxxxxxxx> --- EXACT STEPS: $ cd /tmp $ git clone https://git.fedorahosted.org/git/fedora-repos.git ~~~ $ cd ./fedora-repos $ make create-archive $ make tag-archive $ rpmlint fedora-repos.spec fedora-repos.spec:10: W: unversioned-explicit-provides fedora-repos(%{version}) fedora-repos.spec: W: invalid-url Source0: fedora-repos-21.tar.bz2 0 packages and 1 specfiles checked; 0 errors, 2 warnings. ~~~ $ mock -r fedora-rawhide-x86_64 --buildsrpm --spec fedora-repos.spec --sources ${PWD} $ cp /var/lib/mock/fedora-rawhide-x86_64/result/fedora-repos-21-0.4.src.rpm /tmp $ rpmlint /tmp/fedora-repos-21-0.4.src.rpm fedora-repos.src: W: spelling-error %description -l en_US dnf -> def, inf, DNA fedora-repos.src: W: spelling-error %description -l en_US gpg -> pg, gig, gag fedora-repos.src:10: W: unversioned-explicit-provides fedora-repos(%{version}) fedora-repos.src: W: invalid-url Source0: fedora-repos-21.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 4 warnings. ~~~ $ mock -r fedora-rawhide-x86_64 --rebuild /tmp/fedora-repos-21-0.4.src.rpm $ cp /var/lib/mock/fedora-rawhide-x86_64/result/fedora-repos-rawhide-21-0.4.noarch.rpm /tmp $ cp /var/lib/mock/fedora-rawhide-x86_64/result/fedora-repos-21-0.4.noarch.rpm /tmp $ rpmlint /tmp/fedora-repos-rawhide-21-0.4.noarch.rpm (none): E: no installed packages by name /tmp/fedora-repos-rawhide-21-0.4.noarch.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings. ~~~ $ rpmlint /tmp/fedora-repos-21-0.4.noarch.rpm fedora-repos.noarch: W: spelling-error %description -l en_US dnf -> def, inf, DNA fedora-repos.noarch: W: spelling-error %description -l en_US gpg -> pg, gig, gag fedora-repos.noarch: W: no-documentation fedora-repos.noarch: W: non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-secondary fedora-repos.noarch: W: non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-primary 1 packages and 0 specfiles checked; 0 errors, 5 warnings. ~~~ $ cd /tmp $ rpmdev-extract /tmp/fedora-repos-21-0.4.noarch.rpm fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-21-fedora fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-aarch64 fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-armhfp fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-i386 fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-ppc64 fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-ppc64le fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-primary fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-s390 fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-s390x fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-secondary fedora-repos-21-0.4.noarch/etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-x86_64 fedora-repos-21-0.4.noarch/etc/yum.repos.d fedora-repos-21-0.4.noarch/etc/yum.repos.d/fedora-updates-testing.repo fedora-repos-21-0.4.noarch/etc/yum.repos.d/fedora-updates.repo fedora-repos-21-0.4.noarch/etc/yum.repos.d/fedora.repo $ rpmdev-extract fedora-repos-rawhide-21-0.4.noarch.rpm fedora-repos-rawhide-21-0.4.noarch/etc/yum.repos.d/fedora-rawhide.repo ~~~ REMARKS: 1) The makefile for creating the source archive is cool. Thanks for adding a note about that in the spec file. 2) The removal of the rm (cleaning) looks better, thanks. 3) The URL is great, thanks for adding that. 4) The versioning appears to address the address concerns about yum.repos.d, thanks. 5) lint warnings are trivial, and ignored. no worries. I'm marking as approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review