https://bugzilla.redhat.com/show_bug.cgi?id=1117077 --- Comment #10 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [-] = Not applicable Issues: ======= - Package must own all directories that it creates. Directories without owner: /usr/share/maven-poms/accumulo (should be owned by core) /usr/lib/java/accumulo (should be owned by tserver) - These BR are not needed: make gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - Scriplets calling ldconfig should be removed because the installed .so file is not in default linker searth path - Description lines must be limited to 80 characters, see rpmlint output below (there is one lite that is too long) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Permissions on files are set properly. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: accumulo-1.6.0-1.fc21.x86_64.rpm accumulo-core-1.6.0-1.fc21.noarch.rpm accumulo-server-base-1.6.0-1.fc21.noarch.rpm accumulo-master-1.6.0-1.fc21.noarch.rpm accumulo-tserver-1.6.0-1.fc21.noarch.rpm accumulo-gc-1.6.0-1.fc21.noarch.rpm accumulo-tracer-1.6.0-1.fc21.noarch.rpm accumulo-examples-1.6.0-1.fc21.noarch.rpm accumulo-native-1.6.0-1.fc21.x86_64.rpm accumulo-javadoc-1.6.0-1.fc21.noarch.rpm accumulo-1.6.0-1.fc21.src.rpm accumulo.x86_64: E: no-binary accumulo.x86_64: W: no-documentation accumulo-core.noarch: W: non-standard-uid /etc/accumulo/accumulo-metrics.xml accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/accumulo-metrics.xml 0640L accumulo-core.noarch: W: non-standard-uid /etc/accumulo/accumulo-env.sh accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/accumulo-env.sh 0750L accumulo-core.noarch: E: non-standard-executable-perm /etc/accumulo/accumulo-env.sh 0750L accumulo-core.noarch: E: executable-marked-as-config-file /etc/accumulo/accumulo-env.sh accumulo-core.noarch: W: non-standard-uid /etc/accumulo/auditLog.xml accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/auditLog.xml 0640L accumulo-core.noarch: W: non-standard-uid /etc/accumulo/monitor_logger.xml accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/monitor_logger.xml 0640L accumulo-core.noarch: W: non-standard-uid /etc/accumulo accumulo accumulo-core.noarch: E: non-standard-dir-perm /etc/accumulo 0750L accumulo-core.noarch: W: non-standard-uid /etc/accumulo/accumulo-site.xml accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/accumulo-site.xml 0640L accumulo-core.noarch: W: non-standard-uid /etc/accumulo/accumulo.policy.example accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/accumulo.policy.example 0640L accumulo-core.noarch: W: non-standard-uid /etc/accumulo/log4j.properties accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/log4j.properties 0640L accumulo-core.noarch: W: non-standard-uid /etc/accumulo/generic_logger.xml accumulo accumulo-core.noarch: E: non-readable /etc/accumulo/generic_logger.xml 0640L accumulo-core.noarch: W: non-standard-uid /var/cache/accumulo accumulo accumulo-core.noarch: E: non-standard-dir-perm /var/cache/accumulo 0750L accumulo-core.noarch: W: no-manual-page-for-binary accumulo accumulo-core.noarch: W: no-manual-page-for-binary accumulo-jar accumulo-core.noarch: W: no-manual-page-for-binary accumulo-rfile-info accumulo-core.noarch: W: no-manual-page-for-binary accumulo-zookeeper accumulo-core.noarch: W: no-manual-page-for-binary accumulo-create-token accumulo-core.noarch: W: no-manual-page-for-binary accumulo-classpath accumulo-core.noarch: W: no-manual-page-for-binary accumulo-version accumulo-core.noarch: W: no-manual-page-for-binary accumulo-info accumulo-core.noarch: W: no-manual-page-for-binary accumulo-login-info accumulo-core.noarch: W: no-manual-page-for-binary accumulo-shell accumulo-server-base.noarch: E: description-line-too-long C This package provides the base Java libraries for other Apache Accumulo services. accumulo-server-base.noarch: W: no-documentation accumulo-server-base.noarch: W: no-manual-page-for-binary accumulo-admin accumulo-server-base.noarch: W: no-manual-page-for-binary accumulo-init accumulo-master.noarch: W: no-documentation accumulo-master.noarch: W: no-manual-page-for-binary accumulo-master accumulo-tserver.noarch: W: no-documentation accumulo-tserver.noarch: W: no-manual-page-for-binary accumulo-tserver accumulo-gc.noarch: W: no-documentation accumulo-gc.noarch: W: no-manual-page-for-binary accumulo-gc accumulo-tracer.noarch: W: no-documentation accumulo-tracer.noarch: W: no-manual-page-for-binary accumulo-tracer accumulo-examples.noarch: W: no-documentation accumulo-native.x86_64: W: spelling-error %description -l en_US tserver -> server, t server, serve accumulo-native.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 14 errors, 35 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review