https://bugzilla.redhat.com/show_bug.cgi?id=1088645 Florian "der-flo" Lehner <dev@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dev@xxxxxxxxxxx Flags| |fedora-review? --- Comment #3 from Florian "der-flo" Lehner <dev@xxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 75 files have unknown license. ---> Please add a note about the license to the *.c-file upstream [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. ---> why isn't the package named thc-ipv6? thc-ipv6 is fine with https://fedoraproject.org/wiki/Packaging:NamingGuidelines and https://www.thc.org/thc-ipv6/ uses it, too [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7118313 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: thcipv6-2.5-1.fc21.x86_64.rpm thcipv6-2.5-1.fc21.src.rpm thcipv6.x86_64: E: incorrect-fsf-address /usr/share/doc/thcipv6/LICENSE.OPENSSL thcipv6.x86_64: W: no-manual-page-for-binary dump_dhcp6 thcipv6.x86_64: W: no-manual-page-for-binary dnssecwalk thcipv6.x86_64: W: no-manual-page-for-binary rsmurf6 thcipv6.x86_64: W: no-manual-page-for-binary trace6 thcipv6.x86_64: W: no-manual-page-for-binary inverse_lookup6 thcipv6.x86_64: W: no-manual-page-for-binary smurf6 thcipv6.x86_64: W: no-manual-page-for-binary flood_redir6 thcipv6.x86_64: W: no-manual-page-for-binary fake_dns6d thcipv6.x86_64: W: no-manual-page-for-binary dump_router6 thcipv6.x86_64: W: no-manual-page-for-binary fake_mldrouter6 thcipv6.x86_64: W: no-manual-page-for-binary fuzz_ip6 thcipv6.x86_64: W: no-manual-page-for-binary fuzz_dhcps6 thcipv6.x86_64: W: no-manual-page-for-binary flood_advertise6 thcipv6.x86_64: W: no-manual-page-for-binary four2six thcipv6.x86_64: W: no-manual-page-for-binary covert_send6d thcipv6.x86_64: W: no-manual-page-for-binary fake_router6 thcipv6.x86_64: W: no-manual-page-for-binary fake_mld6 thcipv6.x86_64: W: no-manual-page-for-binary extract_hosts6.sh thcipv6.x86_64: W: no-manual-page-for-binary flood_dhcpc6 thcipv6.x86_64: W: no-manual-page-for-binary denial6 thcipv6.x86_64: W: no-manual-page-for-binary fake_pim6 thcipv6.x86_64: W: no-manual-page-for-binary dos-new-ip6 thcipv6.x86_64: W: no-manual-page-for-binary toobig6 thcipv6.x86_64: W: no-manual-page-for-binary covert_send6 thcipv6.x86_64: W: no-manual-page-for-binary flood_mld26 thcipv6.x86_64: W: no-manual-page-for-binary fake_solicitate6 thcipv6.x86_64: W: no-manual-page-for-binary passive_discovery6 thcipv6.x86_64: W: no-manual-page-for-binary fake_dnsupdate6 thcipv6.x86_64: W: no-manual-page-for-binary ndpexhaust6 thcipv6.x86_64: W: no-manual-page-for-binary flood_mldrouter6 thcipv6.x86_64: W: no-manual-page-for-binary fake_router26 thcipv6.x86_64: W: no-manual-page-for-binary thcsyn6 thcipv6.x86_64: W: no-manual-page-for-binary redirsniff6 thcipv6.x86_64: W: no-manual-page-for-binary flood_router26 thcipv6.x86_64: W: no-manual-page-for-binary implementation6d thcipv6.x86_64: W: no-manual-page-for-binary fake_mld26 thcipv6.x86_64: W: no-manual-page-for-binary fake_advertise6 thcipv6.x86_64: W: no-manual-page-for-binary thc-ipv6-setup.sh thcipv6.x86_64: W: no-manual-page-for-binary dos_mld.sh thcipv6.x86_64: W: no-manual-page-for-binary thcping6 thcipv6.x86_64: W: no-manual-page-for-binary dnsrevenum6 thcipv6.x86_64: W: no-manual-page-for-binary randicmp6 thcipv6.x86_64: W: no-manual-page-for-binary fake_dhcps6 thcipv6.x86_64: W: no-manual-page-for-binary detect-new-ip6 thcipv6.x86_64: W: no-manual-page-for-binary sendpeesmp6 thcipv6.x86_64: W: no-manual-page-for-binary redir6 thcipv6.x86_64: W: no-manual-page-for-binary parasite6 thcipv6.x86_64: W: no-manual-page-for-binary implementation6 thcipv6.x86_64: W: no-manual-page-for-binary address6 thcipv6.x86_64: W: no-manual-page-for-binary flood_mld6 thcipv6.x86_64: W: no-manual-page-for-binary alive6 thcipv6.x86_64: W: no-manual-page-for-binary exploit6 thcipv6.x86_64: W: no-manual-page-for-binary 6to4test.sh thcipv6.x86_64: W: no-manual-page-for-binary extract_networks6.sh thcipv6.x86_64: W: no-manual-page-for-binary detect_sniffer6 thcipv6.x86_64: W: no-manual-page-for-binary flood_solicitate6 thcipv6.x86_64: W: no-manual-page-for-binary dnsdict6 thcipv6.x86_64: W: no-manual-page-for-binary ndpexhaust26 thcipv6.x86_64: W: no-manual-page-for-binary fake_mipv6 thcipv6.x86_64: W: no-manual-page-for-binary inject_alive6 thcipv6.x86_64: W: no-manual-page-for-binary node_query6 thcipv6.x86_64: W: no-manual-page-for-binary flood_router6 thcipv6.x86_64: W: no-manual-page-for-binary kill_router6 thcipv6.x86_64: W: no-manual-page-for-binary flood_rs6 thcipv6.x86_64: W: no-manual-page-for-binary firewall6 thcipv6.x86_64: W: no-manual-page-for-binary fragmentation6 thcipv6.x86_64: W: no-manual-page-for-binary sendpees6 2 packages and 0 specfiles checked; 1 errors, 67 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint thcipv6 thcipv6.x86_64: E: incorrect-fsf-address /usr/share/doc/thcipv6/LICENSE.OPENSSL thcipv6.x86_64: W: no-manual-page-for-binary dump_dhcp6 thcipv6.x86_64: W: no-manual-page-for-binary dnssecwalk thcipv6.x86_64: W: no-manual-page-for-binary rsmurf6 thcipv6.x86_64: W: no-manual-page-for-binary trace6 thcipv6.x86_64: W: no-manual-page-for-binary inverse_lookup6 thcipv6.x86_64: W: no-manual-page-for-binary smurf6 thcipv6.x86_64: W: no-manual-page-for-binary flood_redir6 thcipv6.x86_64: W: no-manual-page-for-binary fake_dns6d thcipv6.x86_64: W: no-manual-page-for-binary dump_router6 thcipv6.x86_64: W: no-manual-page-for-binary fake_mldrouter6 thcipv6.x86_64: W: no-manual-page-for-binary fuzz_ip6 thcipv6.x86_64: W: no-manual-page-for-binary fuzz_dhcps6 thcipv6.x86_64: W: no-manual-page-for-binary flood_advertise6 thcipv6.x86_64: W: no-manual-page-for-binary four2six thcipv6.x86_64: W: no-manual-page-for-binary covert_send6d thcipv6.x86_64: W: no-manual-page-for-binary fake_router6 thcipv6.x86_64: W: no-manual-page-for-binary fake_mld6 thcipv6.x86_64: W: no-manual-page-for-binary extract_hosts6.sh thcipv6.x86_64: W: no-manual-page-for-binary flood_dhcpc6 thcipv6.x86_64: W: no-manual-page-for-binary denial6 thcipv6.x86_64: W: no-manual-page-for-binary fake_pim6 thcipv6.x86_64: W: no-manual-page-for-binary dos-new-ip6 thcipv6.x86_64: W: no-manual-page-for-binary toobig6 thcipv6.x86_64: W: no-manual-page-for-binary covert_send6 thcipv6.x86_64: W: no-manual-page-for-binary flood_mld26 thcipv6.x86_64: W: no-manual-page-for-binary fake_solicitate6 thcipv6.x86_64: W: no-manual-page-for-binary passive_discovery6 thcipv6.x86_64: W: no-manual-page-for-binary fake_dnsupdate6 thcipv6.x86_64: W: no-manual-page-for-binary ndpexhaust6 thcipv6.x86_64: W: no-manual-page-for-binary flood_mldrouter6 thcipv6.x86_64: W: no-manual-page-for-binary fake_router26 thcipv6.x86_64: W: no-manual-page-for-binary thcsyn6 thcipv6.x86_64: W: no-manual-page-for-binary redirsniff6 thcipv6.x86_64: W: no-manual-page-for-binary flood_router26 thcipv6.x86_64: W: no-manual-page-for-binary implementation6d thcipv6.x86_64: W: no-manual-page-for-binary fake_mld26 thcipv6.x86_64: W: no-manual-page-for-binary fake_advertise6 thcipv6.x86_64: W: no-manual-page-for-binary thc-ipv6-setup.sh thcipv6.x86_64: W: no-manual-page-for-binary dos_mld.sh thcipv6.x86_64: W: no-manual-page-for-binary thcping6 thcipv6.x86_64: W: no-manual-page-for-binary dnsrevenum6 thcipv6.x86_64: W: no-manual-page-for-binary randicmp6 thcipv6.x86_64: W: no-manual-page-for-binary fake_dhcps6 thcipv6.x86_64: W: no-manual-page-for-binary detect-new-ip6 thcipv6.x86_64: W: no-manual-page-for-binary sendpeesmp6 thcipv6.x86_64: W: no-manual-page-for-binary redir6 thcipv6.x86_64: W: no-manual-page-for-binary parasite6 thcipv6.x86_64: W: no-manual-page-for-binary implementation6 thcipv6.x86_64: W: no-manual-page-for-binary address6 thcipv6.x86_64: W: no-manual-page-for-binary flood_mld6 thcipv6.x86_64: W: no-manual-page-for-binary alive6 thcipv6.x86_64: W: no-manual-page-for-binary exploit6 thcipv6.x86_64: W: no-manual-page-for-binary 6to4test.sh thcipv6.x86_64: W: no-manual-page-for-binary extract_networks6.sh thcipv6.x86_64: W: no-manual-page-for-binary detect_sniffer6 thcipv6.x86_64: W: no-manual-page-for-binary flood_solicitate6 thcipv6.x86_64: W: no-manual-page-for-binary dnsdict6 thcipv6.x86_64: W: no-manual-page-for-binary ndpexhaust26 thcipv6.x86_64: W: no-manual-page-for-binary fake_mipv6 thcipv6.x86_64: W: no-manual-page-for-binary inject_alive6 thcipv6.x86_64: W: no-manual-page-for-binary node_query6 thcipv6.x86_64: W: no-manual-page-for-binary flood_router6 thcipv6.x86_64: W: no-manual-page-for-binary kill_router6 thcipv6.x86_64: W: no-manual-page-for-binary flood_rs6 thcipv6.x86_64: W: no-manual-page-for-binary firewall6 thcipv6.x86_64: W: no-manual-page-for-binary fragmentation6 thcipv6.x86_64: W: no-manual-page-for-binary sendpees6 1 packages and 0 specfiles checked; 1 errors, 67 warnings. # echo 'rpmlint-done:' Requires -------- thcipv6 (rpmlib, GLIBC filtered): /bin/bash libc.so.6()(64bit) libcrypto.so.10()(64bit) libpcap.so.1()(64bit) libpthread.so.0()(64bit) libresolv.so.2()(64bit) librt.so.1()(64bit) libssl.so.10()(64bit) rtld(GNU_HASH) Provides -------- thcipv6: thcipv6 thcipv6(x86-64) Source checksums ---------------- http://www.thc.org/releases/thc-ipv6-2.5.tar.gz : CHECKSUM(SHA256) this package : 52120bee2da3d25820f021b5c4d6fc79e220e685e2a505b74b48046b608cba8c CHECKSUM(SHA256) upstream package : 52120bee2da3d25820f021b5c4d6fc79e220e685e2a505b74b48046b608cba8c Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1088645 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review