https://bugzilla.redhat.com/show_bug.cgi?id=1117077 --- Comment #8 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> --- I did partial review, the problems I found so far are below. I will continue the review once these problems are fixed. 1) Invalid license tags for some subpackages. If unspecified, license tags are inherited from the previous package, so they need to be explicitly reset in a few packages. 2) Prebuilt bundled binaries in server/monitor/src/main/resources/web. There are 2 problems with some code in the above location: * Bundled libraries are not allowed in Fedora. Bundled files must be removed and packaged separately. * Prebuilt binaries are not allowed in Fedora - everything must be built from source. Obfuscated or "minified" code is not "real" source code in terms of neither The Free Software Definition [1] nor The Open Source Definition [2]. Prebuild code must not be installed. 3) accumulo-native should respect Fedora default compiler flags ($RPM_OPT_FLAGS and $RPM_LD_FLAGS). 4) IMO fedora-integration.patch should be split into separate parts for better readability (one for different version of commons-math, one for skipping some tests and so on), but this is not a blocker. 5) Reason for skipping tests should be documented. Also, some tests are skipped with a patch, which seems redundant. 6) Config files should probably be marked as %config(noreplace) to prevent RPM from overwriting user config during update. [1] http://www.gnu.org/philosophy/free-sw.html [2] http://opensource.org/osd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review