https://bugzilla.redhat.com/show_bug.cgi?id=1115846 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |i@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |i@xxxxxxxx Flags| |fedora-review? --- Comment #3 from Christopher Meng <i@xxxxxxxx> --- (In reply to NIWA Hideyuki from comment #2) > 5. BuildRequires: perl > BuildRequires: perl(AutoLoader) > BuildRequires: perl(Carp) > BuildRequires: perl(Exporter) > BuildRequires: perl(ExtUtils::MakeMaker) > BuildRequires: perl(IO::Socket) > BuildRequires: perl(strict) > BuildRequires: perl(vars) > Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo > $version)) > > Are all necessary? The unnecessary should be erased. > And, please add comments on explicit dependencies. > > 6. find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; > > It is dangerous rm in %install. Can this be deleted? > > 7. %{_fixperms} $RPM_BUILD_ROOT/* > > Why is this necessary? Can this be deleted? Frankly speaking, you shouldn't review perl packages. Please read this first before doing any informal reviews: http://fedoraproject.org/wiki/Packaging:Perl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review