https://bugzilla.redhat.com/show_bug.cgi?id=1094013 NIWA Hideyuki <niwa.hideyuki@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niwa.hideyuki@xxxxxxxxxxxxx | |m --- Comment #1 from NIWA Hideyuki <niwa.hideyuki@xxxxxxxxxxxxxx> --- Hi This is my informal review. I comment about the spec file etc. SPEC: 1. %global commit 38d7a037 Referring to the following. https://fedoraproject.org/wiki/Packaging:SourceURL#Github 2. Group: Applications/Editors Remove them, no need to keep them now. 3. # Source0 is generated by running Source10, which pulls from the upstream # version control repository. Source0: %{name}-%{checkout}.tar.bz2 Source10: get-sources.sh # Include a copy of the license to comply with license requirements. # https://github.com/ledger/vim-ledger/pull/17 Source20: COPYING URL is necessary for the Source tag. https://fedoraproject.org/wiki/Packaging:SourceURL#Github Please remove source10 and source20. 4. Requires: vim-common Requires(post): vim Requires(postun): vim Please add comments on explicit dependencies. 5. %description %{summary}. Please write a detailed content in description. 6. %prep %setup -q -n %{name}-%{checkout} cp -p %{SOURCE20} . Why is "cp -p %{SOURCE20}" necessary here? 7. %postun rm %{installdir}/doc/tags Please remove "rm %{installdir}/doc/tags". It is dangerous rm in %postun. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review