[Bug 1104746] Review Request: soscleaner - sosreport data obfuscation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1104746

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |tcallawa@xxxxxxxxxx
              Flags|fedora-review?              |fedora-review+



--- Comment #14 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> ---
Package Review
===============

rpmlint reports:

soscleaner.src: W: spelling-error Summary(en_US) sosreport -> misreport,
presort
soscleaner.src: W: file-size-mismatch soscleaner-0.1.tar.gz = 14660,
http://people.redhat.com/jduncan/soscleaner/soscleaner-0.1.tar.gz = 15244
soscleaner.noarch: W: spelling-error Summary(en_US) sosreport -> misreport,
presort

The spelling-errors are false positives, but you should see why the tarballs do
not match.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Simple package, easy review, APPROVED. Please do check that the tarballs match
up before committing the bits to Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]