[Bug 1050744] Review Request: belle-sip - Linphone SIP stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1050744



--- Comment #19 from Christopher Meng <i@xxxxxxxx> ---
(In reply to Jan Kratochvil from comment #18)
> (In reply to nucleo from comment #17)
> > Can you describe what should be done?
> 
> add:
> # The version is used from src/md5.c line:
> # /* $Id: md5.c,v 1.6 2002/04/13 19:20:28 lpd Exp $ */
> Provides: bundled(md5-deutsch) = 1.6

Thanks, finally have a smart people.

> (In reply to Christopher Meng from comment #13)
> > How can you explain other BSD/zlib sources?
> 
> use:
> License: GPLv2+ and BSD and BSD with advertising and MIT
> 
> 
> > Unknown or generated
> > --------------------
> > belle-sip-1.2.4/include/belle-sip/uri.h
>  - no longer exists
> > belle-sip-1.2.4/tester/register_tester.h
>  - belle-sip-1.3.0 has it GPLv2+ marked already
> 
> 
> > zlib/libpng
> > -----------
> > belle-sip-1.2.4/src/md5.c
> > belle-sip-1.2.4/src/md5.h
> 
> Why do you think so?  I would say just BSD.

As Rex has pointed out, mark this package as GPLv2+ should be OK. The rest are
noted in Provides of the bundled lib.

Please fix the spec.

Finally before the approval, please explain why you disable the tests. If no
reason could be given, enable it in the %check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]