https://bugzilla.redhat.com/show_bug.cgi?id=1116548 David Nichols <david@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@xxxxxxxx --- Comment #2 from David Nichols <david@xxxxxxxx> --- an informal review: from rpmlint: g800.x86_64: W: spelling-error %description -l en_US programme -> programmer, programmed, program me http://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description "programme" is a noun (in British English) and should be "program" when used as a verb (also American English should be used as per the link above). from a review of the spec file: in %setup sed -i -e 's|-s|%{?__global_ldflags}|g' \ -e 's|-O3|%{optflags}|g' \ -e 's|-Os|%{optflags}|g' \ Makefile sed -i -e 's|$(EXAMPLE_DOC)|%{_pkgdocdir}/g800config|g' README.Fedora http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment I would take this to mean that the above should include comments. Also I believe that patch is generally preferred over sed from reading other review comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review