https://bugzilla.redhat.com/show_bug.cgi?id=1115121 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |loganjerry@xxxxxxxxx --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- Oops, I'm too late. I was supposed to take this review in exchange. Sorry to be slow. Anyway, I found a few more issues that need to be addressed: 1. The debuginfo package is empty, because install is invoked with the -s option. 2. Parallel make isn't working correctly. The build log shows the same file being compiled by multiple threads; e.g., v.c was built 6 times for me. 3. The package BuildRequires ncurses-devel, but the binary package doesn't depend on any of the ncurses libraries. I also don't see any #include directives that need ncurses present. Finally, I am concerned about introducing /usr/bin/if. That's not only a generic name, but a keyword in pretty much every scripting language in existence. The fact that it is a keyword *probably* means that introducing it as a binary is okay, but ... eek! The name /usr/bin/goto is also somewhat generic. The NOTES file says these are not needed by osh(1), but only by sh6(1). Can we hide them away somehow, perhaps with environment modules? Christopher, if you want to hand me another package for a review swap, please feel free to do so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review