https://bugzilla.redhat.com/show_bug.cgi?id=1115554 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Josef Stribny from comment #1) > * Change upstream URL to git repo (ideally), > http://thoughtbot.com/community/ is just a redirect. Good idea. Not sure why they have this silly URL in gem :/ > * This should be probably filled to upstream (and I realize now its the same > thing for shoulda-context): > > # Fix wrong-file-end-of-line-encoding for rpmlint. > sed -i 's/\r$//' MIT-LICENSE That is questionable. These are Mac line endings, if I was Mac developer, I'd not bother. > * According to the guidelines[0] you should version ruby(release): > > BuildRequires: ruby(release) > BuildRequires: ruby >= 1.9.2 Fixed. > * Package build fails: > > From the log: > > > bundle install --local > > Resolving dependencies... > > Could not find gem 'shoulda-context (~> 1.2.0) ruby' in the gems available on > > this machine. > > You need to BuildRequires: rubygem(shoulda-context) Good catch. I missed it since I had to install it manually into my test build root. Spec URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-shoulda-matchers-2.6.1-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review