[Bug 1115299] Review Request: ceph-deploy - Admin and deploy tool for Ceph

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1115299



--- Comment #6 from Federico Simoncelli <fsimonce@xxxxxxxxxx> ---
(In reply to Christopher Meng from comment #5)
> Not finished yet:
> 
> 1. Source0:        %{name}-%{version}.tar.xz

There's a comment on how to fetch the sources. Anyway the downloaded tgz is not
in the format of %{name}-%{version} (which is the preferred one for the setup
command). I don't think it's worth the trouble to support the direct link and
then have to tweak %setup to match what's downloadable.

> Although RHEL6 is an important market of ceph indeed, you still need to care
> about macros:
> 
> %if 0%{?rhel} && 0%{?rhel} <= 6
> %{!?__python2: %global __python2 /usr/bin/python2}
> %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> %endif

The spec file you just reviewed contained these macros so it should have been
fine.

The rest should be now fixed (build verified both on f21 and el6):

Spec URL: http://fsimonce.fedorapeople.org//ceph-deploy.spec
SRPM URL: http://fsimonce.fedorapeople.org//ceph-deploy-1.5.7-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]