[Bug 1104322] Review Request: python-random2 - Python 2 compatible random module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1104322

Jamie Duncan <jduncan@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jduncan@xxxxxxxxxx



--- Comment #2 from Jamie Duncan <jduncan@xxxxxxxxxx> ---
I'm not an official reviewer, but I'll try and help out where I can. 
I almost wish there was something to say here:

* the only things found by rpmlint are 2 lines it thinks are misspellings in
the long description

Checking: python-random2-1.0.1-1.fc20.noarch.rpm
          python3-random2-1.0.1-1.fc20.noarch.rpm
          python-random2-1.0.1-1.fc20.src.rpm
python-random2.noarch: W: spelling-error %description -l en_US randrange ->
rand range, rand-range, hydrangea
python-random2.noarch: W: spelling-error %description -l en_US randint -> ran
dint, ran-dint, rand int
python3-random2.noarch: W: spelling-error %description -l en_US randrange ->
rand range, rand-range, hydrangea
python3-random2.noarch: W: spelling-error %description -l en_US randint -> ran
dint, ran-dint, rand int
python-random2.src: W: spelling-error %description -l en_US randrange -> rand
range, rand-range, hydrangea
python-random2.src: W: spelling-error %description -l en_US randint -> ran
dint, ran-dint, rand int
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

* source matches as expected
* there are no other dependencies to confirm
* py3 check logic in the spec file looks good

the rpms build cleanly on my fedora 20 test machine and both the py2 and py3
packages look good to me (i did a simple import and dir() of the root module
since I'm not an expert in this subject.

Question:
The spec file denotes the Python license used for distribution. I know that's a
valid license, but I'm not sure what the requirements are but I think at least
a refrence to the license at FSF or similar?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]