Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: FlightGear - Flight Simulator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234826 ------- Additional Comments From fabrice@xxxxxxxxxxx 2007-04-17 19:06 EST ------- (In reply to comment #10) > (In reply to comment #8) > > > 7. Must include a .desktop file (please see > > > http://fedoraproject.org/wiki/Packaging/Guidelines#desktop) > > > > Done. I added a .desktop file, but I didn't find a suitable icon, neither in the > > source tarball, nor in the fgfs-base package. Is it acceptable to ship a > > desktop file without icon ? > > It's VERY preferable to have the icon in place. Please take a look at this: > http://mail.flightgear.org/pipermail/flightgear-devel/2005-September/039106.html > http://jrbabcock.home.comcast.net/flightgear/icons/index.html > > Contact the author of this artwork and see if he will release it under a license > that allows you to use it (and include that license as well). Nice find. I contacted him, and he kindly provides the icons under the GPL license, and updated his web page accordingly. I added the icon to the desktop file, and included all available sizes. > > You also need to add this: > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28scriptlets%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef done. > and > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28scriptlets%29#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda done. New SPEC: http://fr2.rpmfind.net/pub/bellet/review/FlightGear.spec New SRPM: http://fr2.rpmfind.net/pub/bellet/review/FlightGear-0.9.10-6.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review