[Bug 1114749] Review Request: eclipse-webtools - Eclipse Webtools Projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1114749

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Gerard Ryan from comment #3)


> I've changed this now to
> webtools.common/features/org.eclipse.jst.common_core.feature.patch/epl-v10.
> html which is included in the source package. Is this acceptable?
for me yes
> > - Bundled jar/class files should be removed before build
> >   Note: Jar files in source (see attachment)
> >   See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
> >   built_JAR_files_.2F_Other_bundled_software'
> 
> I missed the class files, thanks for pointing it out. They're removed now.
> There's a false positive for the jar file that's reported, since it's a
> directory whose name ends with ".jar":
> 
> > ./webtools.releng.aggregator/webtools.javaee.tests/tests/org.eclipse.jst.j2ee.core.tests/commonArchiveResources/loose_module_workspace/boo.jar

there is this file with different license, maybe, before import, please fix
license field

Apache (v2.0)
-------------
webtools.releng.aggregator/webtools.releng/releng.wtptools/api/org.eclipse.wtp.releng.wtpbuilder/src/org/eclipse/wtp/releng/wtpbuilder/Main.java

org.eclipse.persistence.jpa.jpql is available in eclipselink package (JSR 317)
if you dont need a newer release (JSR 338), please remove.

thanks to you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]