https://bugzilla.redhat.com/show_bug.cgi?id=1105015 --- Comment #2 from Dan Callaghan <dcallagh@xxxxxxxxxx> --- (In reply to Jeff Backus from comment #1) > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > Have you queried upstream re: including the MIT license text in source > tarball? The license is in the tarball as doc/us/license.html (easily missed since it's not included as plain text in the root, like most packages). It's in the corresponding place under /usr/share/doc for the lua-ldap and lua-ldap-compat packages as well. > [-]: %check is present and all tests pass. > Source tarball contains what looks like some sort of test. Maybe add as > %check? I wrote a little script to allow running the tests against a dummy slapd in %check. https://github.com/luaforge/lualdap/pull/2 > [!]: Packages should try to preserve timestamps of original installed files. > Please work with upstream (or create a patch) to change the following > line in the Makefile: > cp src/$(LIBNAME) $(LUA_LIBDIR) > to: > cp -p src/$(LIBNAME) $(LUA_LIBDIR) Preserving timestamps in this case doesn't serve much purpose, since the file is built right before that and is not included in multiple subpackages or anything like that. However I can easily add it. http://fedorapeople.org/~dcallagh/lua-ldap/lua-ldap.spec http://fedorapeople.org/~dcallagh/lua-ldap/lua-ldap-1.1.0-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review