https://bugzilla.redhat.com/show_bug.cgi?id=1067003 --- Comment #5 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- The package looks good, there are only a couple mostly cosmetic issues : - blank line at top of spec. - it would be clearer to not mix Requires and BuildRequires. Move the only Requires line below the last BuildRequires line. - the %defattr line in the %files section is not needed for anything but EL5. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review