[Bug 1094015] Review Request: cwtex-q-fonts - a series of modern traditional Chinese fonts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1094015



--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
rpmlint on source and binary rpms gave
cwtex-q-fangsong-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/cwtex-q-fangsong-fonts/license.txt
cwtex-q-fonts.src:37: W: macro-in-comment %package
cwtex-q-fonts.src:41: W: macro-in-comment %description
cwtex-q-fonts.src:42: W: macro-in-comment %common_desc
cwtex-q-fonts.src:44: W: macro-in-comment %{name}
cwtex-q-fonts.src:50: W: macro-in-comment %{name}
cwtex-q-fonts.src:50: W: macro-in-comment %{version}
cwtex-q-fonts.src:50: W: macro-in-comment %{release}
cwtex-q-fonts.src:64: W: macro-in-comment %{name}
cwtex-q-fonts.src:64: W: macro-in-comment %{version}
cwtex-q-fonts.src:64: W: macro-in-comment %{release}
cwtex-q-fonts.src:78: W: macro-in-comment %{name}
cwtex-q-fonts.src:78: W: macro-in-comment %{version}
cwtex-q-fonts.src:78: W: macro-in-comment %{release}
cwtex-q-fonts.src:92: W: macro-in-comment %{name}
cwtex-q-fonts.src:92: W: macro-in-comment %{version}
cwtex-q-fonts.src:92: W: macro-in-comment %{release}
cwtex-q-fonts.src:106: W: macro-in-comment %{name}
cwtex-q-fonts.src:106: W: macro-in-comment %{version}
cwtex-q-fonts.src:106: W: macro-in-comment %{release}
cwtex-q-fonts.src:159: W: macro-in-comment %files
cwtex-q-fonts.src:160: W: macro-in-comment %defattr
cwtex-q-fonts.src:161: W: macro-in-comment %doc
cwtex-q-fonts.src: W: invalid-url Source0: cwtex-q-fonts-v02-1.tar.xz
cwtex-q-hei-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/cwtex-q-hei-fonts/license.txt
cwtex-q-kai-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/cwtex-q-kai-fonts/license.txt
cwtex-q-ming-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/cwtex-q-ming-fonts/license.txt
cwtex-q-yuan-fonts.noarch: W: spelling-error %description -l en_US yaun ->
yuan, yarn, faun
cwtex-q-yuan-fonts.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/cwtex-q-yuan-fonts/license.txt
6 packages and 0 specfiles checked; 0 errors, 29 warnings.

==> Fix for above issues are as
1) when writing macros in comments always add extra % so %{name} should be
%%{name}

2) wrong-file-end-of-line-encoding messages, fix this by using
https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding

3) In the changelog you don't need dist tag i.e. change
 0.2-1%{?dist}
to
 0.2-1

4) For fedora packaging only you don't need now
  a) removal of buildroot in %install
  b) %clean section
See more about this https://fedoraproject.org/wiki/PackagingGuidelines#.25clean
and https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

I did not like the -common for just few (here 2) files which becomes one more
dependent package for all other fonts subpackages. So, decide if you want to
keep -common in your package then enable lines in comments else remove lines
with comments.

Note with every update to package you should increase release tag number by 1
and submit new package for further review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]