[Bug 1113405] Review Request: ibus-libzhuyin - New Zhuyin engine based on libzhuyin for IBus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1113405

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---

suggestions:
1) Package should add either BR: python2-devel or python3-devel

2) rpmlint output on rpms gave
ibus-libzhuyin.src: E: description-line-too-long C It includes a Chinese Zhuyin
(Bopomofo) input method based on libzhuyin for IBus.
ibus-libzhuyin.src:42: W: macro-in-comment %find_lang
ibus-libzhuyin.src:42: W: macro-in-comment %{name}
ibus-libzhuyin.src:44: W: macro-in-comment %files
ibus-libzhuyin.src:44: W: macro-in-comment %{name}
ibus-libzhuyin.src: W: file-size-mismatch ibus-libzhuyin-1.6.99.20140626.tar.gz
= 458962,
http://downloads.sourceforge.net/libzhuyin/ibus-libzhuyin/ibus-libzhuyin-1.6.99.20140626.tar.gz
= 458946
ibus-libzhuyin.x86_64: E: description-line-too-long C It includes a Chinese
Zhuyin (Bopomofo) input method based on libzhuyin for IBus.
ibus-libzhuyin.x86_64: E: zero-length /usr/share/doc/ibus-libzhuyin/NEWS
ibus-libzhuyin.x86_64: W: install-file-in-docs
/usr/share/doc/ibus-libzhuyin/INSTALL
3 packages and 0 specfiles checked; 3 errors, 6 warnings.

Fix the above rpmlint messages

3) If this package is only for Fedora then remove lines
Group:      System Environment/Libraries

rm -rf $RPM_BUILD_ROOT

%defattr(-,root,root,-)

4) Change 
make DESTDIR=${RPM_BUILD_ROOT} install
to
make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p"

5) No option available "--enable-opencc" to ./configure as its default enabled

6) Looks like package is failing to build for F20 but passed on F21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]