[Bug 1112864] Review Request: elpa - High-performance library for parallel solution of eigenvalue problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1112864



--- Comment #6 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
(In reply to Sandro Mani from comment #2)
> Issues:
> - A comment why %{?_smp_mflags} is disabled would be nice
> - Comment how to obtain source tarball

Fixed. After talking to upstream again, I found the right homepage URL and
links to source tarballs there.

> - Unowned directory issues:
>   * No package seems to own %{_libdir}/gfortran (possibly gfortran should do
> so?)

Fixed by adding the missing Requires on gcc-gfortran, as Dave pointed out.

>   * Same goes with %{_libdir}/*mpi*/pkgconfig
> - rpmlint
>   * undefined-non-weak-symbol : these should be fixable my linking against
> the mpi / gomp libraries

I managed to fix that, but I'm still getting undefined symbols due to a bug in
scalapack package. Bug 1113567 filed.

>   * unused-direct-shlib-dependency : could try -Wl,--as-needed

It fails at linking when I add that. Also, these come from linking with mpif90
(which is as it turns out required to avoid the undefined mpi symbols). I'll
keep trying to fix that.

> Note:
> - Spec in SRPM differs

I'll keep the %if 0 there to allow disabling tests for quick local builds.

New spec and srpm:

http://rathann.fedorapeople.org/review/elpa/elpa.spec
http://rathann.fedorapeople.org/review/elpa/elpa-2013.11-2.008.fc20.src.rpm

* Thu Jun 26 2014 Dominik Mierzejewski <rpm@xxxxxxxxxxxxxx> 2013.11-2.008
- remove executable stack from installed libraries
- fix undefined non-weak mpi symbols
- reorder build section and drop some redundant parts
- add missing gfortran Requires for -devel subpackages
- use correct URL and provide link to source tarball

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]