Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: samba https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226387 ------- Additional Comments From dmitry@xxxxxxxxxxxx 2007-04-17 11:17 EST ------- Still pending remarks: - Does "/usr/lib* instead of %{_libdir}" hack still needed for the latest upstream versions? - docs/manpages contain non-ascii non-UTF8 symbols (yet not checked out for 3.0.25 :) ). Non-UTF8 is deprecated now. (BTW, run f.e. "man smbd" and see the man's warning in the first 3 lines). - Init scripts: /etc/rc.d/init.d/finctions existance is checked "hardly", whereas /etc/sysconfig/network is not... Since the init scripts are separate sources for Fedora, it can be fixed easily. - winbind.init: /var/lock/subsys name should match the initscript name, i.e. should be "/var/lock/subsys/winbind", not ".../winbindd" (rmplint complains about it). Since "/var/cache/samba" is no more used, maybe create a symlink to /var/lib/samba? (at least "for compatibility reasons" :) ) Perhaps this way (old and new places are playing together) the migration procedure could be simplified... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review