https://bugzilla.redhat.com/show_bug.cgi?id=1112864 --- Comment #2 from Sandro Mani <manisandro@xxxxxxxxx> --- Issues: - A comment why %{?_smp_mflags} is disabled would be nice - Comment how to obtain source tarball - Unowned directory issues: * No package seems to own %{_libdir}/gfortran (possibly gfortran should do so?) * Same goes with %{_libdir}/*mpi*/pkgconfig - rpmlint * undefined-non-weak-symbol : these should be fixable my linking against the mpi / gomp libraries * unused-direct-shlib-dependency : could try -Wl,--as-needed Note: - Spec in SRPM differs Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: sed See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/gfortran, /usr/lib64/gfortran/modules, /usr/lib64/openmpi/lib/pkgconfig, /usr/lib64/gfortran/modules/mpich, /usr/lib64/mpich/lib/pkgconfig, /usr/lib64/gfortran/modules/openmpi => Not a blocker since there are no packages which provide these directories [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/gfortran, /usr/lib64/openmpi/lib, /usr/lib64/gfortran/modules, /usr/lib64/mpich, /usr/lib64/mpich/lib, /usr/lib64/openmpi/lib/pkgconfig, /usr/lib64/gfortran/modules/mpich, /usr/lib64/mpich/lib/pkgconfig, /usr/lib64/openmpi, /usr/lib64/gfortran/modules/openmpi => Not a blocker since there are no packages which provide these directories [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: elpa-common-2013.11-1.008.fc21.noarch.rpm elpa-mpich-2013.11-1.008.fc21.x86_64.rpm elpa-mpich-devel-2013.11-1.008.fc21.x86_64.rpm elpa-openmpi-2013.11-1.008.fc21.x86_64.rpm elpa-openmpi-devel-2013.11-1.008.fc21.x86_64.rpm elpa-2013.11-1.008.fc21.src.rpm elpa-mpich.x86_64: W: no-documentation elpa-mpich-devel.x86_64: W: only-non-binary-in-usr-lib elpa-mpich-devel.x86_64: W: no-documentation elpa-openmpi.x86_64: W: no-documentation elpa-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib elpa-openmpi-devel.x86_64: W: no-documentation elpa.src: W: spelling-error %description -l en_US eigenvector -> convector elpa.src: W: spelling-error %description -l en_US eigenproblem -> problematic elpa.src: W: invalid-url Source0: ELPA_2013.11.tar.xz 6 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint elpa-mpich-devel elpa-openmpi-devel elpa-common elpa-openmpi elpa-mpich elpa-mpich-devel.x86_64: W: only-non-binary-in-usr-lib elpa-mpich-devel.x86_64: W: no-documentation elpa-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib elpa-openmpi-devel.x86_64: W: no-documentation elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_reduce_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_isend_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_comm_split_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_abort_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_test_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_comm_rank_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_sendrecv_replace_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_wait_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_wtime_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_waitall_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_sendrecv_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_irecv_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_barrier_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_alltoallv_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_recv_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_send_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_allreduce_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_comm_size_ elpa-openmpi.x86_64: W: undefined-non-weak-symbol /usr/lib64/openmpi/lib/libelpa.so.0.0.0 mpi_bcast_ elpa-openmpi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libelpa.so.0.0.0 libscalapack.so.2 elpa-openmpi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libelpa.so.0.0.0 libmpiblacs.so.2 elpa-openmpi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libelpa.so.0.0.0 /lib64/libstdc++.so.6 elpa-openmpi.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libelpa.so.0.0.0 /lib64/libgcc_s.so.1 elpa-openmpi.x86_64: W: no-documentation elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_reduce_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 GOMP_parallel elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_isend_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_comm_split_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_abort_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_test_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_comm_rank_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_sendrecv_replace_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_wait_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_wtime_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 omp_get_thread_num_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_waitall_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_sendrecv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_irecv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_barrier_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 omp_get_num_threads_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 omp_get_num_threads elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_alltoallv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_recv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_send_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_allreduce_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 omp_get_max_threads_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 GOMP_barrier elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_comm_size_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 omp_get_thread_num elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 mpi_bcast_ elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 libscalapack.so.2 elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 libmpiblacs.so.2 elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 /lib64/libstdc++.so.6 elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa_mt.so.0.0.0 /lib64/libgcc_s.so.1 elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_reduce_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_isend_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_comm_split_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_abort_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_test_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_comm_rank_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_sendrecv_replace_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_wait_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_wtime_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_waitall_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_sendrecv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_irecv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_barrier_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_alltoallv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_recv_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_send_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_allreduce_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_comm_size_ elpa-mpich.x86_64: W: undefined-non-weak-symbol /usr/lib64/mpich/lib/libelpa.so.0.0.0 mpi_bcast_ elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa.so.0.0.0 libscalapack.so.2 elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa.so.0.0.0 libmpiblacs.so.2 elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa.so.0.0.0 /lib64/libstdc++.so.6 elpa-mpich.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libelpa.so.0.0.0 /lib64/libgcc_s.so.1 elpa-mpich.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 82 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/sandro/.Data/Desktop/1112864-elpa/srpm/elpa.spec 2014-06-25 15:52:47.784991580 +0200 +++ /home/sandro/.Data/Desktop/1112864-elpa/srpm-unpacked/elpa.spec 2014-06-24 10:56:21.000000000 +0200 @@ -195,5 +195,4 @@ rm %{buildroot}%{_bindir}/test* -%if 0 %check %{_mpich_load} @@ -212,5 +211,4 @@ popd %{_openmpi_unload} -%endif %post mpich -p /sbin/ldconfig Requires -------- elpa-mpich-devel (rpmlib, GLIBC filtered): elpa-mpich(x86-64) libelpa.so.0()(64bit) libelpa_mt.so.0()(64bit) elpa-openmpi-devel (rpmlib, GLIBC filtered): elpa-openmpi(x86-64) libelpa.so.0()(64bit) elpa-common (rpmlib, GLIBC filtered): elpa-openmpi (rpmlib, GLIBC filtered): /sbin/ldconfig blacs-openmpi elpa-common libblas.so.3()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) liblapack.so.3()(64bit) libm.so.6()(64bit) libmpiblacs.so.2()(64bit) libscalapack.so.2()(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) scalapack-openmpi elpa-mpich (rpmlib, GLIBC filtered): /sbin/ldconfig blacs-mpich elpa-common libblas.so.3()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) liblapack.so.3()(64bit) libm.so.6()(64bit) libmpiblacs.so.2()(64bit) libscalapack.so.2()(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) scalapack-mpich Provides -------- elpa-mpich-devel: elpa-mpich-devel elpa-mpich-devel(x86-64) elpa-openmpi-devel: elpa-openmpi-devel elpa-openmpi-devel(x86-64) elpa-common: elpa-common elpa-openmpi: elpa-openmpi elpa-openmpi(x86-64) libelpa.so.0()(64bit) elpa-mpich: elpa-mpich elpa-mpich(x86-64) libelpa.so.0()(64bit) libelpa_mt.so.0()(64bit) Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1112864 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review