[Bug 1111242] Review Request: perl-App-s2p - Convert sed script to Perl program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1111242

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Spec file changes:

--- perl-App-s2p.spec.old       2014-06-24 09:39:36.000000000 +0200
+++ perl-App-s2p.spec   2014-06-25 16:51:01.000000000 +0200
@@ -2,7 +2,7 @@
 Version:        1.001
 Release:        1%{?dist}
 Summary:        Convert sed script to Perl program
-License:        GPL+ or Artistic
+License:        (GPL+ or Artistic) and App-s2p
 Group:          Development/Tools
 URL:            http://search.cpan.org/dist/App-s2p/
 Source0:       
http://www.cpan.org/authors/id/L/LE/LEONT/App-s2p-%{version}.tar.gz
@@ -10,7 +10,7 @@
 BuildRequires:  perl
 BuildRequires:  perl(Config)
 BuildRequires:  perl(Devel::FindPerl) >= 0.009
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
 BuildRequires:  perl(File::Copy)
 BuildRequires:  perl(File::Spec)
 BuildRequires:  perl(integer)

> FIX: The script/s2p license
-License:        GPL+ or Artistic
+License:        (GPL+ or Artistic) and App-s2p
Ok.

> TODO: Constrain `perl(ExtUtils::MakeMaker)' build-requirement with `>= 6.30'
> (Makefile.PL:10).
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
Ok.

$ rpmlint perl-App-s2p.spec ../SRPMS/perl-App-s2p-1.001-1.fc21.src.rpm
../RPMS/noarch/perl-App-s2p-1.001-1.fc21.noarch.rpm 
perl-App-s2p.src: W: spelling-error Summary(en_US) sed -> tied, ed, seed
perl-App-s2p.src: W: spelling-error %description -l en_US sed -> tied, ed, seed
perl-App-s2p.src: W: invalid-license App-s2p
perl-App-s2p.noarch: W: spelling-error Summary(en_US) sed -> tied, ed, seed
perl-App-s2p.noarch: W: spelling-error %description -l en_US sed -> tied, ed,
seed
perl-App-s2p.noarch: W: invalid-license App-s2p
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]