https://bugzilla.redhat.com/show_bug.cgi?id=1111181 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 675b5fd8b1cfe62b13229f42e6282ce0d61c8fd4574af9a2c3aaad75617a6fc3). Ok. Summary verified from lib/WWW/DuckDuckGo.pm. Ok. Description verified from lib/WWW/DuckDuckGo.pm. Ok. TODO: Capitalize the HTTPS and HTTP protocol names in the description. License verified from README, lib/WWW/DuckDuckGo/Link.pm, lib/WWW/DuckDuckGo/ZeroClickInfo.pm, lib/WWW/DuckDuckGo/Icon.pm, lib/WWW/DuckDuckGo.pm, and LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: Do not build-require `perl(Test::Pod)'. It's not used when running tests (t/release-pod-syntax.t:4). All tests pass. Ok. $ rpmlint perl-WWW-DuckDuckGo.spec ../SRPMS/perl-WWW-DuckDuckGo-0.016-1.fc21.src.rpm ../RPMS/noarch/perl-WWW-DuckDuckGo-0.016-1.fc21.noarch.rpm perl-WWW-DuckDuckGo.src: W: spelling-error %description -l en_US https -> HTTP perl-WWW-DuckDuckGo.src: W: spelling-error %description -l en_US http -> HTTP perl-WWW-DuckDuckGo.noarch: W: spelling-error %description -l en_US https -> HTTP perl-WWW-DuckDuckGo.noarch: W: spelling-error %description -l en_US http -> HTTP 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-WWW-DuckDuckGo-0.016-1.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Jun 24 16:36 /usr/share/doc/perl-WWW-DuckDuckGo -rw-r--r-- 1 root root 1176 Dec 10 2013 /usr/share/doc/perl-WWW-DuckDuckGo/Changes -rw-r--r-- 1 root root 18440 Dec 10 2013 /usr/share/doc/perl-WWW-DuckDuckGo/LICENSE -rw-r--r-- 1 root root 328 Dec 10 2013 /usr/share/doc/perl-WWW-DuckDuckGo/README -rw-r--r-- 1 root root 2060 Jun 24 16:36 /usr/share/man/man3/WWW::DDG.3pm.gz -rw-r--r-- 1 root root 2883 Jun 24 16:36 /usr/share/man/man3/WWW::DuckDuckGo.3pm.gz -rw-r--r-- 1 root root 2513 Jun 24 16:36 /usr/share/man/man3/WWW::DuckDuckGo::Icon.3pm.gz -rw-r--r-- 1 root root 2525 Jun 24 16:36 /usr/share/man/man3/WWW::DuckDuckGo::Link.3pm.gz -rw-r--r-- 1 root root 3124 Jun 24 16:36 /usr/share/man/man3/WWW::DuckDuckGo::ZeroClickInfo.3pm.gz drwxr-xr-x 2 root root 0 Jun 24 16:36 /usr/share/perl5/vendor_perl/WWW -rw-r--r-- 1 root root 706 Dec 10 2013 /usr/share/perl5/vendor_perl/WWW/DDG.pm drwxr-xr-x 2 root root 0 Jun 24 16:36 /usr/share/perl5/vendor_perl/WWW/DuckDuckGo -rw-r--r-- 1 root root 5314 Dec 10 2013 /usr/share/perl5/vendor_perl/WWW/DuckDuckGo.pm -rw-r--r-- 1 root root 2029 Dec 10 2013 /usr/share/perl5/vendor_perl/WWW/DuckDuckGo/Icon.pm -rw-r--r-- 1 root root 2307 Dec 10 2013 /usr/share/perl5/vendor_perl/WWW/DuckDuckGo/Link.pm -rw-r--r-- 1 root root 7439 Dec 10 2013 /usr/share/perl5/vendor_perl/WWW/DuckDuckGo/ZeroClickInfo.pm File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-WWW-DuckDuckGo-0.016-1.fc21.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(HTTP::Request) 1 perl(JSON) >= 2.50 1 perl(LWP::UserAgent) 1 perl(Moo) >= 0.009007 1 perl(URI) >= 1.58 1 perl(URI::QueryParam) 1 perl(WWW::DuckDuckGo::Icon) 1 perl(WWW::DuckDuckGo::Link) 1 perl(WWW::DuckDuckGo::ZeroClickInfo) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-WWW-DuckDuckGo-0.016-1.fc21.noarch.rpm | sort -f | uniq -c 1 perl(WWW::DDG) = 0.016 1 perl(WWW::DuckDuckGo) = 0.016 1 perl(WWW::DuckDuckGo::Icon) = 0.016 1 perl(WWW::DuckDuckGo::Link) = 0.016 1 perl(WWW::DuckDuckGo::ZeroClickInfo) = 0.016 1 perl-WWW-DuckDuckGo = 0.016-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-WWW-DuckDuckGo-0.016-1.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7071616). Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review