[Bug 1110913] Review Request: pam_script - PAM module for executing scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1110913



--- Comment #5 from Lubomir Rintel <lkundrak@xxxxx> ---
* Package named correctly
* Latest version packaged
* License OK for fedora
* License text included
- License not field correct (see below)
* SPEC file clean and legible
* Builds fine in mock
* Requires sane
* Provides sane
* Filelist sane
* Proper compiler flags used

0.) Please use correct GitHub source file

"For a number of reasons (immutability, availability, uniqueness), you must use
the full commit revision hash when referring to the sources."

http://fedoraproject.org/wiki/Packaging:SourceURL#Github

-Source0: https://github.com/jeroennijhof/pam_script/archive/%{version}.tar.gz
+Source0:       
https://github.com/$OWNER/$PROJECT/archive/%{commit}/$PROJECT-%{commit}.tar.gz

1.) License is likely GPLv2+, not GPLv2

See the "or later version" clause in:
https://github.com/jeroennijhof/pam_script/blob/master/pam_script.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]