https://bugzilla.redhat.com/show_bug.cgi?id=1089213 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #17 from Haïkel Guémar <karlthered@xxxxxxxxx> --- Since this packages complies with Fedora general and Python specific guidelines, I hereby approve it into Fedora Packages Collection. Formal review is posted below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 9 files have unknown license. Detailed output of licensecheck in /home/haikel/1089213-openstack-trove/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /etc/logrotate.d, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openstack- trove-common , openstack-trove-api , openstack-trove-taskmanager , openstack-trove-conductor , openstack-trove-guestagent , python-trove [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openstack-trove-2014.1-6.fc21.noarch.rpm openstack-trove-common-2014.1-6.fc21.noarch.rpm openstack-trove-api-2014.1-6.fc21.noarch.rpm openstack-trove-taskmanager-2014.1-6.fc21.noarch.rpm openstack-trove-conductor-2014.1-6.fc21.noarch.rpm openstack-trove-guestagent-2014.1-6.fc21.noarch.rpm python-trove-2014.1-6.fc21.noarch.rpm openstack-trove-2014.1-6.fc21.src.rpm openstack-trove.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-common.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-common.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure openstack-trove-common.noarch: W: non-standard-gid /etc/trove/trove.conf trove openstack-trove-common.noarch: E: non-readable /etc/trove/trove.conf 0640L openstack-trove-common.noarch: W: non-standard-uid /var/run/trove trove openstack-trove-common.noarch: W: non-standard-uid /var/lib/trove trove openstack-trove-common.noarch: W: non-standard-gid /var/lib/trove trove openstack-trove-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-trove openstack-trove-common.noarch: W: non-standard-uid /var/log/trove trove openstack-trove-common.noarch: W: no-manual-page-for-binary trove-mgmt-taskmanager openstack-trove-common.noarch: W: no-manual-page-for-binary trove-manage openstack-trove-api.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-api.noarch: W: only-non-binary-in-usr-lib openstack-trove-api.noarch: W: no-documentation openstack-trove-api.noarch: W: no-manual-page-for-binary trove-api openstack-trove-taskmanager.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-taskmanager.noarch: W: only-non-binary-in-usr-lib openstack-trove-taskmanager.noarch: W: no-documentation openstack-trove-taskmanager.noarch: W: non-standard-gid /etc/trove/trove-taskmanager.conf trove openstack-trove-taskmanager.noarch: E: non-readable /etc/trove/trove-taskmanager.conf 0640L openstack-trove-taskmanager.noarch: W: no-manual-page-for-binary trove-taskmanager openstack-trove-conductor.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-conductor.noarch: W: only-non-binary-in-usr-lib openstack-trove-conductor.noarch: W: no-documentation openstack-trove-conductor.noarch: W: non-standard-gid /etc/trove/trove-conductor.conf trove openstack-trove-conductor.noarch: E: non-readable /etc/trove/trove-conductor.conf 0640L openstack-trove-conductor.noarch: W: no-manual-page-for-binary trove-conductor openstack-trove-guestagent.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-guestagent.noarch: W: only-non-binary-in-usr-lib openstack-trove-guestagent.noarch: W: no-documentation openstack-trove-guestagent.noarch: W: non-standard-gid /etc/trove/trove-guestagent.conf trove openstack-trove-guestagent.noarch: E: non-readable /etc/trove/trove-guestagent.conf 0640L openstack-trove-guestagent.noarch: W: non-standard-gid /etc/trove/guest_info trove openstack-trove-guestagent.noarch: E: non-readable /etc/trove/guest_info 0640L openstack-trove-guestagent.noarch: W: no-manual-page-for-binary trove-guestagent python-trove.noarch: E: explicit-lib-dependency python-httplib2 python-trove.noarch: E: explicit-lib-dependency python-passlib python-trove.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/couchbase/config.template python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/mongodb/override.config.template python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/redis/override.config.template python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/couchbase/override.config.template openstack-trove.src: W: spelling-error %description -l en_US codename -> code name, code-name, codependent 8 packages and 0 specfiles checked; 12 errors, 32 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint openstack-trove-guestagent openstack-trove-common openstack-trove-api openstack-trove python-trove openstack-trove-taskmanager openstack-trove-conductor openstack-trove-guestagent.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-guestagent.noarch: W: only-non-binary-in-usr-lib openstack-trove-guestagent.noarch: W: no-documentation openstack-trove-guestagent.noarch: W: non-standard-gid /etc/trove/trove-guestagent.conf trove openstack-trove-guestagent.noarch: E: non-readable /etc/trove/trove-guestagent.conf 0640L openstack-trove-guestagent.noarch: W: non-standard-gid /etc/trove/guest_info trove openstack-trove-guestagent.noarch: E: non-readable /etc/trove/guest_info 0640L openstack-trove-guestagent.noarch: W: no-manual-page-for-binary trove-guestagent openstack-trove-common.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-common.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure openstack-trove-common.noarch: W: non-standard-gid /etc/trove/trove.conf trove openstack-trove-common.noarch: E: non-readable /etc/trove/trove.conf 0640L openstack-trove-common.noarch: W: non-standard-uid /var/run/trove trove openstack-trove-common.noarch: W: non-standard-uid /var/lib/trove trove openstack-trove-common.noarch: W: non-standard-gid /var/lib/trove trove openstack-trove-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-trove openstack-trove-common.noarch: W: non-standard-uid /var/log/trove trove openstack-trove-common.noarch: W: no-manual-page-for-binary trove-mgmt-taskmanager openstack-trove-common.noarch: W: no-manual-page-for-binary trove-manage openstack-trove-api.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-api.noarch: W: only-non-binary-in-usr-lib openstack-trove-api.noarch: W: no-documentation openstack-trove-api.noarch: W: no-manual-page-for-binary trove-api openstack-trove.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent python-trove.noarch: E: explicit-lib-dependency python-httplib2 python-trove.noarch: E: explicit-lib-dependency python-passlib python-trove.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/couchbase/config.template python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/mongodb/override.config.template python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/redis/override.config.template python-trove.noarch: E: zero-length /usr/lib/python2.7/site-packages/trove/templates/couchbase/override.config.template openstack-trove-taskmanager.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-taskmanager.noarch: W: only-non-binary-in-usr-lib openstack-trove-taskmanager.noarch: W: no-documentation openstack-trove-taskmanager.noarch: W: non-standard-gid /etc/trove/trove-taskmanager.conf trove openstack-trove-taskmanager.noarch: E: non-readable /etc/trove/trove-taskmanager.conf 0640L openstack-trove-taskmanager.noarch: W: no-manual-page-for-binary trove-taskmanager openstack-trove-conductor.noarch: W: spelling-error %description -l en_US codename -> code name, code-name, codependent openstack-trove-conductor.noarch: W: only-non-binary-in-usr-lib openstack-trove-conductor.noarch: W: no-documentation openstack-trove-conductor.noarch: W: non-standard-gid /etc/trove/trove-conductor.conf trove openstack-trove-conductor.noarch: E: non-readable /etc/trove/trove-conductor.conf 0640L openstack-trove-conductor.noarch: W: no-manual-page-for-binary trove-conductor 7 packages and 0 specfiles checked; 12 errors, 31 warnings. # echo 'rpmlint-done:' Requires -------- openstack-trove-guestagent (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(openstack-trove-guestagent) openstack-trove-common python-pexpect openstack-trove-common (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(openstack-trove-common) python-trove shadow-utils systemd openstack-trove-api (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python openstack-trove-common openstack-trove (rpmlib, GLIBC filtered): openstack-trove-api openstack-trove-conductor openstack-trove-taskmanager python-trove (rpmlib, GLIBC filtered): MySQL-python python(abi) python-babel python-cinderclient python-eventlet python-greenlet python-heatclient python-httplib2 python-iso8601 python-jinja2 python-jsonschema python-keystoneclient python-kombu python-lxml python-migrate python-netaddr python-novaclient python-oslo-config python-passlib python-paste-deploy python-qpid python-routes python-sqlalchemy python-swiftclient python-troveclient python-webob openstack-trove-taskmanager (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(openstack-trove-taskmanager) openstack-trove-common openstack-trove-conductor (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(openstack-trove-conductor) openstack-trove-common Provides -------- openstack-trove-guestagent: config(openstack-trove-guestagent) openstack-trove-guestagent openstack-trove-common: config(openstack-trove-common) openstack-trove-common openstack-trove-api: openstack-trove-api openstack-trove: openstack-trove python-trove: python-trove openstack-trove-taskmanager: config(openstack-trove-taskmanager) openstack-trove-taskmanager openstack-trove-conductor: config(openstack-trove-conductor) openstack-trove-conductor Source checksums ---------------- https://launchpad.net/trove/icehouse/2014.1/+download/trove-2014.1.tar.gz : CHECKSUM(SHA256) this package : 8a9cec9e32e3eb9522f90221fe7387b6cbc3de18d138a7c8d9ee5e48f89c57b7 CHECKSUM(SHA256) upstream package : 8a9cec9e32e3eb9522f90221fe7387b6cbc3de18d138a7c8d9ee5e48f89c57b7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review