Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fonts-japanese https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225765 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-04-17 03:27 EST ------- Review: + package builds in mock (development i386). - rpmlint is NOT silent for SRPM. W: fonts-japanese rpm-buildroot-usage %build %configure --disable-bold --disable-italic --with-fontdir=$RPM_BUILD_ROOT%{bmpfontdir} $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. ===> the above is OK for this package as its only installing font files. + rpmlint is silent for RPM. + source files match upstream. e8a452c07cd5d1d31d3a6f32c2b74265 jisksp14.bdf.gz d0d24d605ee62833234b711d6766e16c jisksp16-1990.bdf.gz c59fc33f4319a291c1f3f7d58d896b9c k14-oldkanji.tar.gz e0a103ceeffe0aa1c5670458f47452b3 kaname_k12_bdf.tar.gz 065920714d022cfd225feb6d80b03238 knm_new.tar.gz a97a99acbee54976407dec828d03850c mplus_bitmap_fonts-2.2.4.tar.gz e0e1d3b139159a2af09bc9867c9a654b warabi12-0.19a.tar.gz 19ff56e6de82e8f9a02c9cebf5af0cdc Kappa20-0.396.tar.bz2 b312f77829011547b19fc16956dc6f12 sazanami-20061016.tar.bz2 38ce9221d128383a3f9f50eb641da424 shinonome-0.9.11-src.tar.bz2 b3900ebac6dd1044423bef5e23d653dc imamura-jisx0213.tgz a412bc6920d29be2689b3c3192bcdbd2 marumoji.tgz c6b7771e4f00e310fe807b3245fd316e vine-fonttools-0.1.tgz fa5981d270f432d36818329c8878ba6e xfonts_jp.tgz 77d997789026b1829bb4a33f65a0ce78 jiskan16-1990.bdf.Z c9fd21064b4ad6f1af0bcdb40a4222ee jiskano16-1997.bdf.Z + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + Used Fonts Scriptlet. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Provides: fonts-ja = 8.0-16 jisksp14 = 0.1-16 jisksp16-1990 = 0.1-16 kappa20 = 0.3-15 knm_new = 1.1-16 ttfonts-ja = 1.2-37 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review