https://bugzilla.redhat.com/show_bug.cgi?id=1111691 --- Comment #19 from David Nichols <david@xxxxxxxx> --- (In reply to David Nichols from comment #18) > OK I have it like this now: > Provides: qore-module(abi) = 0.19 > Provides: qore-module(abi) = 0.18 > Provides: libqore5 = %{version} > Obsoletes: libqore5 < 0.8.11.1 > > I also updated the module (and library) ABI because I moved the user (text) > modules to $(datarootdir)/qore-modules (ie /usr/share/qore-modules/...) to > address one of the fedora-review issues, and for this I also added > additional symbols to the library. > > However now I'm getting a new error in fedora-review as follows: > libqore.x86_64: E: useless-provides qore-module(abi) I also checked https://apps.fedoraproject.org/packages/audacious/sources/spec and see that audacious-libs only uses one versioned Provides: declaration for audacious(plugin-api) (they also use %{?_isa} in the declaration, which I've added). So basically the question is if: Provides: qore-module(abi)%{?_isa} = 0.19 %{?_isa:Provides: qore-module(abi) = 0.19} Provides: qore-module(abi)%{?_isa} = 0.18 %{?_isa:Provides: qore-module(abi) = 0.18} is OK despite the error in fedora-review (libqore.x86_64: E: useless-provides qore-module(abi)). I found another fedora package (rubygem-em-socksify) that passed review with this error, so maybe it's ok - not totally clear to me why it's not a warning if under some circumstances it's OK. Anyway, assuming it's OK, the new URLs are: Spec URL: http://qore.org/srpms/qore.spec SRPM URL: http://qore.org/srpms/qore-0.8.11.1-1.fc20.src.rpm Changes: - added explicit versioned capability for library ABI compatibility for module RPMs - added explicit versioned capability for libqore5 due to name change on fedora/rhel - obsoletes previous versions of libqore5 in case of foreign RPM installation - added %%{optflags} to configure - updated license text in library source to reflect most liberal license option (MIT) with reference to LGPL and GPL options - replaced GPL getopt_long.* files with BSD variants (not used on Linux builds) - updated module and library ABI info - moved user module directory to ${_datarootdir} - moved module and user module directories to libqore package where they should be - disabled dependency tracking in configure The upstream source has been significantly updated with the license text updates as mentioned above. There are still some GPL files included in licensecheck.txt: ltmain.sh (included by autotools from libtool) and parser.cpp/parser.hpp which are generated by Bison and subject to the Bison "special exception". there are some rpmlint warnings still present, but I hope they are acceptable (the spelling ones are definitely OK I believe). There are missing man pages for two programs used in C++ development for libqore, and the devel documentation is in a separate package due to its size, so there are no docs in the devel package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review