[Bug 1112072] Review Request: vit - A minimalist Taskwarrior full-screen terminal interface with Vim key bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1112072



--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Benedikt Morbach from comment #1)
> Note: this review is unofficial/preliminary.
> 
> > rpmlint:
> > vit.noarch: W: manual-page-warning /usr/share/man/man5/vitrc.5.gz 61: cannot use character `*' as a starting delimiter
> 
> This seems to be an actual error in the man page.
> I would suggest this, which seems to give me the correct output:
> -.B map c=:! task %TASKID rc.defaultwidth:200 | grep -o -P -m 1
> "(ftp|http)s?://\S*" | tr -d '\n' | xsel -b<Return>
> +.B map c=:! task %TASKID rc.defaultwidth:200 | grep -o -P -m 1
> "(ftp|http)s?://\\\\S*" | tr -d '\n' | xsel -b<Return>
> 
> Did you submit the Makefile.in patch upstream?
> If yes, please add a link to the bug report.
> If not, please do that, it will make maintenance easier down the line.
> Same for the man page.
> 
> The final 1.2 release seems to be out
> (http://taskwarrior.org/news/news.20140406.html).



Hi Benedikt,

Thanks for the comments and the fix for the man page. I'm already in
communication with upstream via e-mail, but I've gone ahead and filed bugs too. 

Updated spec/srpm:
http://ankursinha.fedorapeople.org/vit/vit.spec

http://ankursinha.fedorapeople.org/vit/vit-1.2-1.fc21.src.rpm

No rpmlint warnings any more.

Thanks,
Warm regards,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]