[Bug 1089213] Review Request: openstack-trove - OpenStack DBaaS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1089213



--- Comment #10 from Haïkel Guémar <karlthered@xxxxxxxxx> ---
A first pass.

Requirements could be simplified:
* python-heatclient pulls in python-httplib2, python-iso8601, and
python-keystoneclient (which pulls in python-babel)
* python-keystoneclient pulls in python-oslo-config (which pulls-in
python-argparse and python-six)

Removing unnecessary explicit requires is a MUST, but that's an issue affecting
all openstack packages.

As for the configuration files, they are set to 0640 in all openstack-*
packages so I assume this is an implicit convention.

About the patches:
* version.diff: set a placeholder that is replaced at packages build time using
sed
* authtoken.diff: authentication configuration
* db-config.diff: database configuration 
* el6-parallel-deps.diff: EL6 (alas usual) hack to use the right version of
some python modules (sqlalchemy, routes, etc.)
These are RDO specific patches, so non-upstreamable, so they're OK.

No unowned directories.

Most of the rpmlint warnings and errors have been answered above.

I have a question: could we remove these files or are they required ?
python-trove.noarch: E: zero-length
/usr/lib/python2.7/site-packages/trove/templates/mongodb/override.config.template
python-trove.noarch: E: zero-length
/usr/lib/python2.7/site-packages/trove/templates/redis/override.config.template
python-trove.noarch: E: zero-length
/usr/lib/python2.7/site-packages/trove/templates/couchbase/override.config.template

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]