https://bugzilla.redhat.com/show_bug.cgi?id=1052852 Mihkel Vain <turakas@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Mihkel Vain <turakas@xxxxxxxxx> --- Spec file looks good to me and fedora-review is not complaining either. APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: glite-lb-utils-2.3.10-2.fc20.x86_64.rpm glite-lb-utils-2.3.10-2.fc20.src.rpm glite-lb-utils.x86_64: W: summary-not-capitalized C gLite Logging and Bookkeeping auxiliary utilities glite-lb-utils.x86_64: W: spelling-error %description -l en_US mon -> Mon, non, min glite-lb-utils.x86_64: W: spelling-error %description -l en_US mortem -> Mort, tremor glite-lb-utils.src: W: summary-not-capitalized C gLite Logging and Bookkeeping auxiliary utilities glite-lb-utils.src: W: spelling-error %description -l en_US mon -> Mon, non, min glite-lb-utils.src: W: spelling-error %description -l en_US mortem -> Mort, tremor 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint glite-lb-utils glite-lb-utils.x86_64: W: summary-not-capitalized C gLite Logging and Bookkeeping auxiliary utilities glite-lb-utils.x86_64: W: spelling-error %description -l en_US mon -> Mon, non, min glite-lb-utils.x86_64: W: spelling-error %description -l en_US mortem -> Mort, tremor 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- glite-lb-utils (rpmlib, GLIBC filtered): /bin/bash glite-lb-state-machine-plugins(x86-64) libc.so.6()(64bit) libdl.so.2()(64bit) libglite_jobid.so.2()(64bit) libglite_jp_common.so.2()(64bit) libglite_lb_client.so.14()(64bit) libglite_lb_clientpp.so.14()(64bit) libglite_lb_common.so.16()(64bit) libglite_lb_statemachine.so.6()(64bit) libglite_lbu_maildir.so.2()(64bit) libglite_lbu_trio.so.2()(64bit) rtld(GNU_HASH) Provides -------- glite-lb-utils: glite-lb-utils glite-lb-utils(x86-64) Source checksums ---------------- http://scientific.zcu.cz/emi/emi.lb.utils/glite-lb-utils-2.3.10.tar.gz : CHECKSUM(SHA256) this package : a967f1b6146b5290edca8e4802bc77eb2fe45b152794149bc6e510ead9f9f5b3 CHECKSUM(SHA256) upstream package : a967f1b6146b5290edca8e4802bc77eb2fe45b152794149bc6e510ead9f9f5b3 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1052852 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review