Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tcpreplay - Replay captured network traffic Alias: tcpreplay https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234812 ------- Additional Comments From bojan@xxxxxxxxxxxxx 2007-04-16 20:20 EST ------- Revised spec and source RPM now available: ftp://ftp.rexursive.com/pub/tcpreplay/tcpreplay.spec ftp://ftp.rexursive.com/pub/tcpreplay/tcpreplay-2.3.5-3.src.rpm The issues addressed: > 1. Please consider to change the install lines in your patch to use install -p to preserve timestamps. Done. > 2. Please change "%doc Docs" to "%doc Docs/*" so that there is not an extraneous single Docs directory in the %doc directory. Done. > 4. CFLAGS are not being used in the compile. This is a blocker. Done. Now setting CFLAGS to RPM_OPT_FLAGS in Makefile explicitly. > 5. Do not include Docs/INSTALL, Docs/WARNINGS. You might also consider only including one format for the same information as far as Docs/*. Done. I only included text and HTML versions (the latter is included because there is an image HTML docs include, which text files cannot point to). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review