https://bugzilla.redhat.com/show_bug.cgi?id=1111691 --- Comment #9 from David Nichols <david@xxxxxxxx> --- (In reply to Michael Schwendt from comment #7) > https://fedoraproject.org/wiki/Packaging:FrequentlyMadeMistakes > > | Increase the "Release" tag every time you upload a new package to avoid > | confusion. The reviewer and other interested parties probably still have > | older versions of your SRPM lying around to check what has changed between > | the old and new packages; those get confused when the revision didn't > change. done - new URLs below > > The %changelog also doesn't document any of the changes you've supplied. > https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs > ok done > > > mv $RPM_BUILD_DIR/%{name}-%{version}/test $RPM_BUILD_DIR/%{name}-%{version}/examples > > "mv test examples" should suffice. > > At the beginning of each of the main spec file sections, you are within the > primary builddir already as specified via %setup (or its default -n > %name-%version). > ok, thanks, done > > > %configure --disable-debug --disable-static > > This belongs at the beginning of the %build section. > Also see "rpm -E %configure". > done > > > %build > > %{__make} > > https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make > > ok done > > %package doc > > Summary: API documentation, programming language reference, and Qore example programs > > Group: Development/Languages > > Rather "Group: Documentation" unless you want to drop the Group tag > altogether: > https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag > ok done > > Requires: libqore%{?_isa} = %{version}-%{release} > > Plain documentation packages (which contain files that can be displayed with > arbitrary HTML/PDF viewers) typically do not need to depend on base > libraries, or else you could not install the documentation without pulling > in dependency bloat. > > ok done > > %package -n libqore > > Summary: The libraries for the qore runtime and qore clients > > Group: Development/Languages > > The Group tag for runtime library base packages has been "System > Environment/Libraries" for many years. > > ok fixed > > %package devel > > Summary: The header files needed to compile programs using the qore library > > Group: Development/Languages > > The Group tag for build-time library -devel packages has been > "Development/Libraries" for many years. > > ok done > > Provides: qore-module-api-0.18 > > Provides: qore-module-api-0.17 > > Provides: qore-module-api-0.16 > > Provides: qore-module-api-0.15 > > Provides: qore-module-api-0.14 > > Provides: qore-module-api-0.13 > > Provides: qore-module-api-0.12 > > Provides: qore-module-api-0.11 > > Provides: qore-module-api-0.10 > > Provides: qore-module-api-0.9 > > Provides: qore-module-api-0.8 > > Provides: qore-module-api-0.7 > > Provides: qore-module-api-0.6 > > Provides: qore-module-api-0.5 > > Odd. And rather limited. You could not do "Requires: qore-module-api >= > 0.10", for example. Why not > > Provides: qore-module(api) = 0.5 > Provides: qore-module(api) = 0.6 > Provides: qore-module(api) = 0.7 > ... > > and so on? > > [...] ok, this makes sense. The reason I did not do it like this before is because I did not come up with this solution when I was first researching this topic. however there are already a set of dependent module RPMs out in the wild (for Fedora, RHEL, and other distributions) that assume the old non-versioned Provides: are available. I would be happy to change it, because I agree that it looks better/cleaner, however I'm afraid of breaking the existing RPMs. So I'm not sure what to do here - any advice you can give would be greatly appreciated. > > Have you pointed the fedora-review tool at this ticket yet? > "fedora-review -b 1111691" I'm running it now against the new SRPM and spec file with: "fedora-review -n qore". It's still running at the moment, so I'll react when I get some output. Thanks for this tip; I did not know about this until now. Thanks a lot for your in-depth review and excellent constructive comments. My packaging knowledge is slowly improving with the state of the qore packaging for Fedora. URLs with updated spec and new SRPM: - Spec URL: http://qore.org/srpms/qore.spec - SRPM URL: http://qore.org/srpms/qore-0.8.11-2.fc20.src.rpm thanks, David -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review