[Bug 1111691] Review Request: qore - multithreaded programming/scripting language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1111691



--- Comment #7 from Michael Schwendt <bugs.michael@xxxxxxx> ---
https://fedoraproject.org/wiki/Packaging:FrequentlyMadeMistakes

| Increase the "Release" tag every time you upload a new package to avoid
| confusion. The reviewer and other interested parties probably still have
| older versions of your SRPM lying around to check what has changed between
| the old and new packages; those get confused when the revision didn't change. 

The %changelog also doesn't document any of the changes you've supplied.
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs


> mv $RPM_BUILD_DIR/%{name}-%{version}/test $RPM_BUILD_DIR/%{name}-%{version}/examples

"mv test examples" should suffice.

At the beginning of each of the main spec file sections, you are within the
primary builddir already as specified via %setup (or its default -n
%name-%version).


> %configure --disable-debug --disable-static

This belongs at the beginning of the %build section.
Also see "rpm -E %configure".


> %build
> %{__make}

https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make


> %package doc
> Summary: API documentation, programming language reference, and Qore example programs
> Group: Development/Languages

Rather "Group: Documentation" unless you want to drop the Group tag altogether:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

> Requires: libqore%{?_isa} = %{version}-%{release}

Plain documentation packages (which contain files that can be displayed with
arbitrary HTML/PDF viewers) typically do not need to depend on base libraries,
or else you could not install the documentation without pulling in dependency
bloat.


> %package -n libqore
> Summary: The libraries for the qore runtime and qore clients
> Group: Development/Languages

The Group tag for runtime library base packages has been "System
Environment/Libraries" for many years.


> %package devel
> Summary: The header files needed to compile programs using the qore library
> Group: Development/Languages

The Group tag for build-time library -devel packages has been
"Development/Libraries" for many years.


> Provides: qore-module-api-0.18
> Provides: qore-module-api-0.17
> Provides: qore-module-api-0.16
> Provides: qore-module-api-0.15
> Provides: qore-module-api-0.14
> Provides: qore-module-api-0.13
> Provides: qore-module-api-0.12
> Provides: qore-module-api-0.11
> Provides: qore-module-api-0.10
> Provides: qore-module-api-0.9
> Provides: qore-module-api-0.8
> Provides: qore-module-api-0.7
> Provides: qore-module-api-0.6
> Provides: qore-module-api-0.5

Odd. And rather limited. You could not do "Requires: qore-module-api >= 0.10",
for example. Why not

  Provides: qore-module(api) = 0.5
  Provides: qore-module(api) = 0.6
  Provides: qore-module(api) = 0.7
  ...

and so on?

[...]

Have you pointed the fedora-review tool at this ticket yet?
"fedora-review -b 1111691"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]