[Bug 1111692] Review Request: purple-whatsapp - Libpurple plug-in for Pidgin and others, supporting WhatsApp protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1111692



--- Comment #2 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> ---
(In reply to Volker Fröhlich from comment #1)
> You don't need a buildroot definition, a clean section and the initial rm in
> the install section. Neither do you need defattr.

Because of Fedora EPEL 5.

> Why are you calling the package purple-whatsapp when the tarball is called
> whatsapp-purple?

Because all other packages in Fedora seem to be named purple-<ext> independent
of the upstream tarball name.

> The version constraint for libpurple is not necessary, as it is fulfilled in
> any version of Fedora.

That is right, but it doesn't hurt as well IMHO.

> The author should provide a license file to include.

Good point, inform upstream about that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]