[Bug 979124] Review Request: qbs - Qt Build Suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979124



--- Comment #49 from Jake Petroules <jake.petroules@xxxxxxxxxxxxx> ---
Few things:

- You've set QBS_LIBRARY_DIRNAME *and* QBS_QBS_LIBRARY_DIRNAME, there should be
no need for the latter if you cherry-picked the patch which fixes this issue
(as you appear to have done in Patch0).
- I'm not sure if it's useful to remove the IB and WiX modules. There's others
that could be removed as well if we go down this route, and it's probably more
hassle than it's worth to continually update that list from version to version,
not to mention the risk of accidentally removing something that's needed (case
in point, you already removed a thing or two by accident in an earlier dev
version). Then again, it might not be as bad if you only exclude things at a
module granularity rather than a file granularity. For example, remove the IB
and WiX modules in their entirety but don't remove DarwinGCC from within the
cpp module. Thoughts?
- Don't manually fix the permissions for the NSIS files; cherry pick
37d7dea3d3db3bd47a5e921de1cf54d48a8736d5 instead and add it as a Patch file.
This fix should be in 1.2.2.

PS - You have BuildRequires nsis, don't forget to add node.js and typescript
when qbs 1.3 comes around.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]