[Bug 1111561] Review Request: git-remote-hg - mercurial wrapper for git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1111561



--- Comment #7 from Ondrej Oprala <ooprala@xxxxxxxxxx> ---
(In reply to Florian "der-flo" Lehner from comment #5)
> [!]: Uses parallel make %{?_smp_mflags} macro.
I don't think that's appropriate here, given that we only install 3 files (and
build only 1).
> [!]: Packages should try to preserve timestamps of original installed files.
>    ---> Looking at the Makefile the timestamps are not preserved.
>         The -p flag of install is missing
install-related parts of the makefile are now substituted in %prep.

Thanks for the review Florian. The links in my initial comment now point to a
corrected spec and srpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]