https://bugzilla.redhat.com/show_bug.cgi?id=1111561 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Christopher Meng <i@xxxxxxxx> --- (In reply to Ondrej Oprala from comment #2) > What do you mean? There's 'BuildArch: noarch' in the spec. Yes, I know that, but if you mark it as noarch, no need to write: %global debug_package %{nil} in the spec. -------- Issues: 1. Since git 2.0.0 will appear(already done) in rawhide only, you should drop all old fashioned rpm syntax: a. rm -rf %{buildroot} in %install b. %clean c. %defattr(-,root,root) 2. Github doesn't provide http connection, URL: http://github.com/felipec/git-remote-hg should be (more accurate) URL: https://github.com/felipec/git-remote-hg 3. /usr should be %{_prefix} 4. Should preserve the timestamp: sed -i -e 's|\tinstall|\tinstall -p|' Makefile -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review