https://bugzilla.redhat.com/show_bug.cgi?id=1111362 Christopher Meng <i@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i@xxxxxxxx --- Comment #1 from Christopher Meng <i@xxxxxxxx> --- I just started packaging this. Welcome to Fedora, your SPEC doesn't follow the guidelines well: 1. These tags should be dropped: Group: System/GUI/Other Packager: Markus Dorfer<markus.dorfer@xxxxxxxxx> --- rm -rf %{buildroot} --- %defattr(-,root,root,-) --- 2. URL: https://github.com/sialan-labs/sigram.git I would use this link: http://labs.sialan.org/projects/sigram 3. Summary tag should be: Telegram client from Sialan.labs 4. BuildRequires: openssl-devel BuildRequires: qt5-qtbase-devel BuildRequires: qt5-qtdeclarative-devel BuildRequires: unzip First, you need to know that it's better for Qt packages to use pkgconfig when finding qt modules: http://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires Then for some of these lines below, you shouldn't include them in SPEC as RPM has dependency generator, when you BuildRequires something, the Requires will be finished by RPM during the install: Requires: qt5-qtquickcontrols >= 5 Requires: qt5-qtbase >= 5 Requires: qt5-qtbase-gui >= 5 Requires: qt5-qtdeclarative >= 5 Requires: qt5-qtgraphicaleffects >= 5 e.g if you BR'ed BuildRequires: qt5-qtbase-devel BuildRequires: qt5-qtdeclarative-devel As declared before, these should be finished by RPM: Requires: qt5-qtbase >= 5 Requires: qt5-qtdeclarative >= 5 yum install qt-creator qt5-qtbase qt5-qtbase-devel qt5-qtdeclarative qt5-qtquick1 qt5-qtquick1-devel kde-plasma-applicationname kde-plasma-nm qt5-qtdeclarative-devel qt5-qtdeclarative-static qt5-qtgraphicaleffects Seems that qt5-qtquick1-devel is missing in your spec? The last, no need to add ">= 5", it's nonsensical. 5. %description Telegram Client for Linux written in QT5. Too short, please take a look at the upstream website/readme file to rewrite a new one. 6. %build mkdir build && cd build qmake-qt5 -o Makefile ../SialanTelegram.pro make %{?_snmp_mflags} 1) You should use RPM macro %_qt5_qmake, the meaning of this macro can be found via: $ rpm -E %_qt5_qmake And I think %_qt5_qmake ../SialanTelegram.pro is enough, no other option needed. 2) make %{?_snmp_mflags} Typo, should be: make %{?_smp_mflags} 7. %install install -d %{buildroot}/usr/bin/ install -d %{buildroot}/usr/share/applications/ install -d %{buildroot}/usr/share/sigram/ install -d %{buildroot}/usr/share/pixmaps/ cp -r $RPM_BUILD_DIR/%{name}-%{version}/build/countries database emojis fonts translations %{buildroot}%{_datadir}/sigram/ cp -r $RPM_BUILD_DIR/%{name}-%{version}/build/icons/icon.png %{buildroot}%{_datadir}/pixmaps/sigram.png install $RPM_BUILD_DIR/%{name}-%{version}/build/tg-server.pub %{buildroot}%{_datadir}/sigram/ install $RPM_BUILD_DIR/%{name}-%{version}/build/SialanTelegram %{buildroot}%{_datadir}/sigram/ install %{SOURCE2} %{buildroot}%{_datadir}/applications/sigram.desktop install -m 0755 %{SOURCE1} %{buildroot}/usr/bin/%{name} 1) install -d %{buildroot}/usr/bin/ install -d %{buildroot}/usr/share/applications/ install -d %{buildroot}/usr/share/sigram/ install -d %{buildroot}/usr/share/pixmaps/ *Please learn how to use macros consistently*: https://fedoraproject.org/wiki/Packaging:RPMMacros 2) Please preserve timestamps while doing file actions. https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 3) install %{SOURCE2} %{buildroot}%{_datadir}/applications/sigram.desktop Please learn how to use desktop-file-install: https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files 8. Source0: %{name}-%{version}.tar.gz Ask upstream to tag the project, and follow the tarball link trick here: http://pkgs.fedoraproject.org/cgit/git-cola.git/tree/git-cola.spec#n7 --------------------------- Based on your spec I think you have 0 knowledge of Fedora guidelines, please follow this page step by step if you want to be sponsored successfully: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review