Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: jakarta-commons-modeler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225934 pcheung@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From pcheung@xxxxxxxxxx 2007-04-16 14:46 EST ------- (In reply to comment #3) > (In reply to comment #2) > > X verify source and patches (md5sum matches upstream, know what the patches do) > > - if upstream doesn't release source drops, put *clear* instructions on > > how to generate the the source drop; ie. > > - Please provide instructions/URL for Source0 > Fixed Great, md5sum match. > > * skim the summary and description for typos, etc. > > X correct buildroot > > - should be: > > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > - Please fix buildroot > Fixed Thanks. > > > X summary should be a short and concise description of the package > > - Summary is only the name of the package > > - Description references to 'preceding section' without including that section > > in there. > Fixed > Thanks. > Updated srpm: > https://mwringe.108.redhat.com/files/documents/175/341/jakarta-commons-modeler-2.0-3jpp.1.src.rpm * verify the final provides and requires of the binary RPMs [pcheung@to-fcjpp1 review]$ rpm -qp --provides /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-2.0-3jpp.1.fc7.x86_64.rpm commons-modeler = 0:2.0-3jpp.1.fc7 jakarta-commons-modeler-2.0.jar.so()(64bit) jakarta-commons-modeler = 0:2.0-3jpp.1.fc7 [pcheung@to-fcjpp1 review]$ rpm -qp --requires /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-2.0-3jpp.1.fc7.x86_64.rpm /bin/sh /bin/sh jakarta-commons-beanutils >= 0:1.3 jakarta-commons-collections >= 0:2.0 jakarta-commons-digester >= 0:1.2 jakarta-commons-logging >= 0:1.0 java-gcj-compat java-gcj-compat jaxp_parser_impl jaxp_transform_impl jmxri libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcj_bc.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libz.so.1()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) xml-commons-apis [pcheung@to-fcjpp1 review]$ rpm -qp --provides /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-debuginfo-2.0-3jpp.1.fc7.x86_64.rpm jakarta-commons-modeler-2.0.jar.so.debug()(64bit) jakarta-commons-modeler-debuginfo = 0:2.0-3jpp.1.fc7 [pcheung@to-fcjpp1 review]$ rpm -qp --requires /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-debuginfo-2.0-3jpp.1.fc7.x86_64.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [pcheung@to-fcjpp1 review]$ rpm -qp --provides /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-javadoc-2.0-3jpp.1.fc7.x86_64.rpm jakarta-commons-modeler-javadoc = 0:2.0-3jpp.1.fc7 [pcheung@to-fcjpp1 review]$ rpm -qp --requires /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-javadoc-2.0-3jpp.1.fc7.x86_64.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 * run rpmlint on the binary RPMs [pcheung@to-fcjpp1 review]$ rpmlint /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-2.0-3jpp.1.fc7.x86_64.rpm W: jakarta-commons-modeler non-standard-group Development/Libraries/Java [pcheung@to-fcjpp1 review]$ rpmlint /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-debuginfo-2.0-3jpp.1.fc7.x86_64.rpm [pcheung@to-fcjpp1 review]$ rpmlint /var/lib/mock/fedora-development-x86_64-core-pcheung/result/jakarta-commons-modeler-javadoc-2.0-3jpp.1.fc7.x86_64.rpm W: jakarta-commons-modeler-javadoc non-standard-group Development/Documentation These are OK. Everything looks good. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review