https://bugzilla.redhat.com/show_bug.cgi?id=1110945 --- Comment #11 from Antonio Trande <anto.trande@xxxxxxxxx> --- - Fix License tag: LBNL BSD - Patch0 is not applied. - You can build a -doc subpackage to include all html documentation, examples, scripts directories and their respective README files. - Perl: [?]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? Probably it's related to the perl scripts contained in scripts/ directory. I don't know if it's enough add just a 'Requires: perl%{?_isa}', sorry. - manual-page-warning are related to presumed formatting problems of the manpages. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5038080 bytes in 282 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 55 files have unknown license. Detailed output of licensecheck in /home/sagitter/1110945-voro++/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [?]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5058560 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: voro++-0.4.6-5.fc21.i686.rpm voro++-devel-0.4.6-5.fc21.i686.rpm voro++-0.4.6-5.fc21.src.rpm voro++.i686: W: spelling-error %description -l en_US Voro -> Moro, Voronezh voro++.i686: W: spelling-error %description -l en_US centroid -> centrist voro++.i686: W: invalid-license LBNLBSD voro++.i686: W: shared-lib-calls-exit /usr/lib/libvoro++.so.0.0.0 exit@GLIBC_2.0 voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 85: warning: numeric expression expected (got `s') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 100: warning: numeric expression expected (got `o') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 108: warning: numeric expression expected (got `l') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 117: warning: numeric expression expected (got `m') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 123: warning: numeric expression expected (got `n') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 181: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 188: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 193: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 197: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 200: warning: numeric expression expected (got `x') voro++-devel.i686: W: spelling-error Summary(en_US) voro -> Moro, Voronezh voro++-devel.i686: W: summary-not-capitalized C voro++ headers voro++-devel.i686: W: spelling-error %description -l en_US voro -> Moro, Voronezh voro++-devel.i686: W: invalid-license LBNLBSD voro++.src: W: spelling-error %description -l en_US Voro -> Moro, Voronezh voro++.src: W: spelling-error %description -l en_US centroid -> centrist voro++.src: W: invalid-license LBNLBSD voro++.src: W: patch-not-applied Patch0: voro++_virtual-destructor.patch 3 packages and 0 specfiles checked; 0 errors, 22 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint voro++ voro++-devel voro++.i686: W: spelling-error %description -l en_US Voro -> Moro, Voronezh voro++.i686: W: spelling-error %description -l en_US centroid -> centrist voro++.i686: W: invalid-license LBNLBSD voro++.i686: W: shared-lib-calls-exit /usr/lib/libvoro++.so.0.0.0 exit@GLIBC_2.0 voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 85: warning: numeric expression expected (got `s') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 100: warning: numeric expression expected (got `o') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 108: warning: numeric expression expected (got `l') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 117: warning: numeric expression expected (got `m') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 123: warning: numeric expression expected (got `n') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 181: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 188: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 193: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 197: warning: numeric expression expected (got `x') voro++.i686: W: manual-page-warning /usr/share/man/man1/voro++.1.gz 200: warning: numeric expression expected (got `x') voro++-devel.i686: W: spelling-error Summary(en_US) voro -> Moro, Voronezh voro++-devel.i686: W: summary-not-capitalized C voro++ headers voro++-devel.i686: W: spelling-error %description -l en_US voro -> Moro, Voronezh voro++-devel.i686: W: invalid-license LBNLBSD 2 packages and 0 specfiles checked; 0 errors, 18 warnings. # echo 'rpmlint-done:' Requires -------- voro++ (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libvoro++.so.0 rtld(GNU_HASH) voro++-devel (rpmlib, GLIBC filtered): libvoro++.so.0 voro++(x86-32) Provides -------- voro++: libvoro++.so.0 voro++ voro++(x86-32) voro++-devel: voro++-devel voro++-devel(x86-32) Source checksums ---------------- http://math.lbl.gov/voro++/download/dir/voro++-0.4.6.tar.gz : CHECKSUM(SHA256) this package : ef7970071ee2ce3800daa8723649ca069dc4c71cc25f0f7d22552387f3ea437e CHECKSUM(SHA256) upstream package : ef7970071ee2ce3800daa8723649ca069dc4c71cc25f0f7d22552387f3ea437e Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -b 1110945 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review