https://bugzilla.redhat.com/show_bug.cgi?id=1110913 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@xxxxx --- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> --- 0.) Why would this be needed? %posttrans restorecon %{_sysconfdir}/pam_script* restorecon %{_sysconfdir}/pam-script.d/ 1.) The %el5 conditionals are way too ugly Please remove them -- if you wish to support el5, feel free to -- just remove the conditions, the obsolete rpm artifacts such as %clean section or BuildRoot are ignored anyway. 2.) Mark the files in /etc as %config(noreplace) %dir %{_sysconfdir}/pam-script.d/ %{_sysconfdir}/pam_script* Not sure why didn't rpmlint warn you. 3.) The dangling "cd -" is probably left there by accident. Please remove it 4.) Please comment non-obvious stuff you do: e.g. why would you do this? cp etc/README etc/README.module_types autoreconf -vfi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review