Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: sendmail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226407 ------- Additional Comments From paul@xxxxxxxxxxxx 2007-04-16 13:16 EST ------- rpmlint looks OK now apart from: W: sendmail mixed-use-of-spaces-and-tabs (spaces: line 868, tab: line 2) some very minor cosmetic changes to the changelog can fix this The provides for "MTA" and smtpdaemon are well before the rest of the provides in the spec; it'd be good if they were all together. Requires(postun) doesn't need to include chkconfig Requires: openssl (with_tls, with_sasl, with_ldap) is redundant; autodetected library dependencies will pull in the correct package if sendmail is built against openssl. Similarly, Requires: openldap is redundant. %description doc says that "papers are provided in PostScript(TM) and troff formats" but it's now a PDF. The "touch" and initial "chmod" parts of "create db files" in %install are redundant because the files were created in the immediately preceding part of the spec, and with the correct permissions. Installation of %{maildir}/Makefile would be better grouped with the installation of the other files in %{maildir} above "create db files" rather than grouped with the initscript installation. Still no comment on using /etc/mail/Makefile for map rebuilds in %post? %attr(0755,root,root) for %{_initrddir}/sendmail in $files is redundant as those are the attributes it would have by default. So, mainly those are cosmetic changes and in general I'm happy with this. Any more comments from anyone else before I approve this one? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review