[Bug 1094214] Review Request: rubygem-pdf-core - PDF::Core is used by Prawn to render PDF documents

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1094214

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* rpmlint output:
  - rubygem-pdf-core.noarch: E: useless-provides rubygem(pdf-core)

    This provide is now autogenerated and can be removed from spec file.

  - rubygem-pdf-core.noarch: E: incorrect-fsf-address
      /usr/share/gems/gems/pdf-core-0.2.5/GPLv2

    You should ask upstream to fix the address.

* Confusing Patch0 comment
  - Seems that the patch relaxes dependency on pdf-reader, not on pdf-core.
  - Why is the dependency so tight? Or why not make it explicit, if you
override
    the defaults anyway?

Otherwise, the package looks sane => APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]