https://bugzilla.redhat.com/show_bug.cgi?id=1070406 --- Comment #8 from Christopher Meng <i@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Header files in -devel subpackage, if present. Note: signon-doc : /usr/share/doc/signon-plugins-dev/example/exampledata.h signon-doc : /usr/share/doc/signon-plugins-dev/example/exampleplugin.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 24412160 bytes in 1101 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "LGPL (v2.1)". 3 files have unknown license. Detailed output of licensecheck: LGPL (v2.1) ----------- signon-8.56/lib/SignOn/async-dbus-proxy.cpp signon-8.56/lib/SignOn/async-dbus-proxy.h signon-8.56/lib/SignOn/authservice.cpp signon-8.56/lib/SignOn/authservice.h signon-8.56/lib/SignOn/authserviceimpl.cpp signon-8.56/lib/SignOn/authserviceimpl.h signon-8.56/lib/SignOn/authsession.cpp signon-8.56/lib/SignOn/authsession.h signon-8.56/lib/SignOn/authsessionimpl.cpp signon-8.56/lib/SignOn/authsessionimpl.h signon-8.56/lib/SignOn/connection-manager.cpp signon-8.56/lib/SignOn/connection-manager.h signon-8.56/lib/SignOn/dbusinterface.cpp signon-8.56/lib/SignOn/dbusinterface.h signon-8.56/lib/SignOn/identity.cpp signon-8.56/lib/SignOn/identity.h signon-8.56/lib/SignOn/identityimpl.cpp signon-8.56/lib/SignOn/identityimpl.h signon-8.56/lib/SignOn/identityinfo.cpp signon-8.56/lib/SignOn/identityinfo.h signon-8.56/lib/SignOn/identityinfoimpl.cpp signon-8.56/lib/SignOn/identityinfoimpl.h signon-8.56/lib/SignOn/libsignoncommon.h signon-8.56/lib/SignOn/sessiondata.h signon-8.56/lib/SignOn/signon.h signon-8.56/lib/SignOn/signonerror.h signon-8.56/lib/plugins/SignOn/authpluginif.h signon-8.56/lib/plugins/SignOn/signonplugincommon.h signon-8.56/lib/plugins/SignOn/uisessiondata.h signon-8.56/lib/plugins/SignOn/uisessiondata_priv.h signon-8.56/lib/plugins/signon-plugins-common/SignOn/blobiohandler.cpp signon-8.56/lib/plugins/signon-plugins-common/SignOn/blobiohandler.h signon-8.56/lib/plugins/signon-plugins-common/SignOn/ipc.h signon-8.56/lib/signond/SignOn/abstract-access-control-manager.cpp signon-8.56/lib/signond/SignOn/abstract-access-control-manager.h signon-8.56/lib/signond/SignOn/abstract-crypto-manager.cpp signon-8.56/lib/signond/SignOn/abstract-crypto-manager.h signon-8.56/lib/signond/SignOn/abstract-key-authorizer.cpp signon-8.56/lib/signond/SignOn/abstract-key-authorizer.h signon-8.56/lib/signond/SignOn/abstract-key-manager.cpp signon-8.56/lib/signond/SignOn/abstract-key-manager.h signon-8.56/lib/signond/SignOn/abstract-secrets-storage.cpp signon-8.56/lib/signond/SignOn/abstract-secrets-storage.h signon-8.56/lib/signond/SignOn/debug.cpp signon-8.56/lib/signond/SignOn/debug.h signon-8.56/lib/signond/SignOn/export.h signon-8.56/lib/signond/SignOn/extension-interface.cpp signon-8.56/lib/signond/SignOn/extension-interface.h signon-8.56/lib/signond/SignOn/key-handler.cpp signon-8.56/lib/signond/SignOn/key-handler.h signon-8.56/lib/signond/SignOn/misc.cpp signon-8.56/lib/signond/SignOn/misc.h signon-8.56/lib/signond/signoncommon.h signon-8.56/src/extensions/cryptsetup/crypto-handlers.cpp signon-8.56/src/extensions/cryptsetup/crypto-handlers.h signon-8.56/src/extensions/cryptsetup/crypto-manager.cpp signon-8.56/src/extensions/cryptsetup/crypto-manager.h signon-8.56/src/extensions/cryptsetup/cryptsetup-plugin.cpp signon-8.56/src/extensions/cryptsetup/cryptsetup-plugin.h signon-8.56/src/extensions/cryptsetup/debug.h signon-8.56/src/extensions/cryptsetup/misc.cpp signon-8.56/src/extensions/cryptsetup/misc.h signon-8.56/src/plugins/example/exampledata.h signon-8.56/src/plugins/example/exampleplugin.cpp signon-8.56/src/plugins/example/exampleplugin.h signon-8.56/src/plugins/password/passwordplugin.cpp signon-8.56/src/plugins/password/passwordplugin.h signon-8.56/src/plugins/test/ssotest2data.h signon-8.56/src/plugins/test/ssotest2plugin.cpp signon-8.56/src/plugins/test/ssotest2plugin.h signon-8.56/src/plugins/test/ssotestplugin.cpp signon-8.56/src/plugins/test/ssotestplugin.h signon-8.56/src/remotepluginprocess/debug.cpp signon-8.56/src/remotepluginprocess/debug.h signon-8.56/src/remotepluginprocess/main.cpp signon-8.56/src/remotepluginprocess/my-network-proxy-factory.h signon-8.56/src/remotepluginprocess/remotepluginprocess.cpp signon-8.56/src/remotepluginprocess/remotepluginprocess.h signon-8.56/src/signond/accesscontrolmanagerhelper.cpp signon-8.56/src/signond/accesscontrolmanagerhelper.h signon-8.56/src/signond/credentialsaccessmanager.cpp signon-8.56/src/signond/credentialsaccessmanager.h signon-8.56/src/signond/credentialsdb.cpp signon-8.56/src/signond/credentialsdb.h signon-8.56/src/signond/credentialsdb_p.h signon-8.56/src/signond/default-crypto-manager.cpp signon-8.56/src/signond/default-crypto-manager.h signon-8.56/src/signond/default-key-authorizer.cpp signon-8.56/src/signond/default-key-authorizer.h signon-8.56/src/signond/default-secrets-storage.cpp signon-8.56/src/signond/default-secrets-storage.h signon-8.56/src/signond/main.cpp signon-8.56/src/signond/pluginproxy.cpp signon-8.56/src/signond/pluginproxy.h signon-8.56/src/signond/signonauthsession.cpp signon-8.56/src/signond/signonauthsession.h signon-8.56/src/signond/signonauthsessionadaptor.cpp signon-8.56/src/signond/signonauthsessionadaptor.h signon-8.56/src/signond/signond-common.h signon-8.56/src/signond/signondaemon.cpp signon-8.56/src/signond/signondaemon.h signon-8.56/src/signond/signondaemonadaptor.cpp signon-8.56/src/signond/signondaemonadaptor.h signon-8.56/src/signond/signondisposable.cpp signon-8.56/src/signond/signondisposable.h signon-8.56/src/signond/signonidentity.cpp signon-8.56/src/signond/signonidentity.h signon-8.56/src/signond/signonidentityadaptor.cpp signon-8.56/src/signond/signonidentityadaptor.h signon-8.56/src/signond/signonidentityinfo.cpp signon-8.56/src/signond/signonidentityinfo.h signon-8.56/src/signond/signonsessioncore.cpp signon-8.56/src/signond/signonsessioncore.h signon-8.56/src/signond/signonsessioncoretools.cpp signon-8.56/src/signond/signonsessioncoretools.h signon-8.56/src/signond/signontrace.h signon-8.56/src/signond/signonui_interface.cpp signon-8.56/src/signond/signonui_interface.h signon-8.56/tests/extensions/tst_access_control_manager.cpp signon-8.56/tests/libsignon-qt-tests/signon-ui.cpp signon-8.56/tests/libsignon-qt-tests/signon-ui.h signon-8.56/tests/libsignon-qt-tests/ssotestclient.cpp signon-8.56/tests/libsignon-qt-tests/ssotestclient.h signon-8.56/tests/libsignon-qt-tests/testauthserviceresult.cpp signon-8.56/tests/libsignon-qt-tests/testauthserviceresult.h signon-8.56/tests/libsignon-qt-tests/testauthsession.cpp signon-8.56/tests/libsignon-qt-tests/testauthsession.h signon-8.56/tests/libsignon-qt-tests/testidentityresult.cpp signon-8.56/tests/libsignon-qt-tests/testidentityresult.h signon-8.56/tests/libsignon-qt-tests/testsinglesignon.cpp signon-8.56/tests/libsignon-qt-tests/testsinglesignon.h signon-8.56/tests/libsignon-qt-tests/testthread.cpp signon-8.56/tests/libsignon-qt-tests/testthread.h signon-8.56/tests/passwordplugintest/passwordplugintest.cpp signon-8.56/tests/passwordplugintest/passwordplugintest.h signon-8.56/tests/signond-tests/backuptest.cpp signon-8.56/tests/signond-tests/backuptest.h signon-8.56/tests/signond-tests/databasetest.cpp signon-8.56/tests/signond-tests/databasetest.h signon-8.56/tests/signond-tests/identity-tool.cpp signon-8.56/tests/signond-tests/include.cpp signon-8.56/tests/signond-tests/mock-ac-plugin/access-control-manager.cpp signon-8.56/tests/signond-tests/mock-ac-plugin/access-control-manager.h signon-8.56/tests/signond-tests/mock-ac-plugin/identity-ac-helper.cpp signon-8.56/tests/signond-tests/mock-ac-plugin/plugin.cpp signon-8.56/tests/signond-tests/mock-ac-plugin/plugin.h signon-8.56/tests/signond-tests/testpluginproxy.cpp signon-8.56/tests/signond-tests/testpluginproxy.h signon-8.56/tests/signond-tests/timeouts.cpp signon-8.56/tests/signond-tests/timeouts.h signon-8.56/tests/signond-tests/tst_access_control.cpp Unknown or generated -------------------- signon-8.56/src/remotepluginprocess/my-network-proxy-factory.cpp signon-8.56/tests/run-with-signond.sh signon-8.56/tests/signond.sh [x]: License file installed when any subpackage combination is installed. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1/services, /usr/share/dbus-1, /usr/lib/cmake, /usr/share/dbus-1/interfaces [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in signon-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 24668160 bytes in /usr/share signon-8.56-3.fc21.i686.rpm:24637440 See: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: signon-8.56-3.fc21.i686.rpm signon-devel-8.56-3.fc21.i686.rpm signon-doc-8.56-3.fc21.noarch.rpm signon-8.56-3.fc21.src.rpm signon.i686: W: spelling-error %description -l en_US login -> loin, logic, lo gin signon.i686: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames signon.i686: W: invalid-url URL: http://code.google.com/p/accounts-sso <urlopen error [Errno 101] Network is unreachable> signon.i686: W: no-manual-page-for-binary signond signon.i686: W: no-manual-page-for-binary signonpluginprocess signon-devel.i686: W: no-documentation signon.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin signon.src: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames signon.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) signon.src: W: invalid-url Source0: http://accounts-sso.googlecode.com/files/signon-8.56.tar.bz2 <urlopen error [Errno 101] Network is unreachable> 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint signon signon-devel signon-doc signon.i686: W: spelling-error %description -l en_US login -> loin, logic, lo gin signon.i686: W: spelling-error %description -l en_US usernames -> user names, user-names, surnames signon.i686: W: invalid-url URL: http://code.google.com/p/accounts-sso <urlopen error [Errno 101] Network is unreachable> signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-extension.so.1.0.0 /lib/libQtXml.so.4 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-extension.so.1.0.0 /lib/libm.so.6 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-extension.so.1.0.0 /lib/libgcc_s.so.1 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-qt.so.1.0.0 /lib/libQtXml.so.4 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-qt.so.1.0.0 /lib/libpthread.so.0 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-qt.so.1.0.0 /lib/libm.so.6 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-qt.so.1.0.0 /lib/libgcc_s.so.1 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-plugins-common.so.1.0.0 /lib/libQtXml.so.4 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-plugins-common.so.1.0.0 /lib/libpthread.so.0 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-plugins-common.so.1.0.0 /lib/libm.so.6 signon.i686: W: unused-direct-shlib-dependency /usr/lib/libsignon-plugins-common.so.1.0.0 /lib/libgcc_s.so.1 signon.i686: W: no-manual-page-for-binary signond signon.i686: W: no-manual-page-for-binary signonpluginprocess signon-devel.i686: W: invalid-url URL: http://code.google.com/p/accounts-sso <urlopen error [Errno 101] Network is unreachable> signon-devel.i686: W: no-documentation signon-doc.noarch: W: invalid-url URL: http://code.google.com/p/accounts-sso <urlopen error [Errno 101] Network is unreachable> 3 packages and 0 specfiles checked; 0 errors, 19 warnings. # echo 'rpmlint-done:' Requires -------- signon (rpmlib, GLIBC filtered): /sbin/ldconfig config(signon) libQtCore.so.4 libQtDBus.so.4 libQtGui.so.4 libQtNetwork.so.4 libQtSql.so.4 libQtXml.so.4 libc.so.6 libgcc_s.so.1 libm.so.6 libproxy.so.1 libpthread.so.0 librt.so.1 libsignon-extension.so.1 libsignon-plugins-common.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) signon-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config glib2-devel(x86-32) libsignon-extension.so.1 libsignon-plugins-common.so.1 libsignon-qt.so.1 pkgconfig(QtCore) pkgconfig(libsignon-qt) signon(x86-32) signon-doc (rpmlib, GLIBC filtered): Provides -------- signon: config(signon) libexampleplugin.so libpasswordplugin.so libsignon-extension.so.1 libsignon-plugins-common.so.1 libsignon-qt.so.1 libssotest2plugin.so libssotestplugin.so signon signon(x86-32) signon-devel: pkgconfig(SignOnExtension) pkgconfig(libsignon-qt) pkgconfig(signon-plugins) pkgconfig(signon-plugins-common) pkgconfig(signond) signon-devel signon-devel(x86-32) signon-doc: signon-doc Unversioned so-files -------------------- signon: /usr/lib/signon/libexampleplugin.so signon: /usr/lib/signon/libpasswordplugin.so signon: /usr/lib/signon/libssotest2plugin.so signon: /usr/lib/signon/libssotestplugin.so Source checksums ---------------- http://accounts-sso.googlecode.com/files/signon-8.56.tar.bz2 : CHECKSUM(SHA256) this package : 48757cd88bf0e7656811a1e68692655029a334d59e4dca985f40bd75aaf67c02 CHECKSUM(SHA256) upstream package : 48757cd88bf0e7656811a1e68692655029a334d59e4dca985f40bd75aaf67c02 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn signon-8.56-3.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- 1. First issue header files can be ignored safely. 2. Unowned directories issue may caused by missing dbus dependency? 3. Tests found, no %check? 4. -doc package is incorrectly-packaged IMO, you can see that the main package signon contains the doc and the duplicated put in -doc again. 5. signon.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10) 6. unused-direct-shlib-dependency errors. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review