https://bugzilla.redhat.com/show_bug.cgi?id=1107441 Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST CC| |bjoern.esser@xxxxxxxxx --- Comment #7 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> --- Good work, Flo! There are just two small things I want to mention, additionally: [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in udt-devel ---> please fix up the requires of the -devel-subpkg. [!]: Packages should try to preserve timestamps of original installed files. ---> `sed 's/\r//' -i doc/doc/udtdoc.css` doesn't preseve the timestamp of that particular file with will be packaged in -devel. ;) Using something like this would be better by the meaning of preserving the file's timestamp: _file="doc/doc/udtdoc.css" sed -e 's!\r$!!g' < ${_file} > ${_file}.new && \ touch -r ${_file} ${_file}.new && \ mv -f ${_file}.new ${_file} Please change those two small accordingly before / during import, Matthias. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review