https://bugzilla.redhat.com/show_bug.cgi?id=978587 --- Comment #6 from Mat Booth <mat.booth@xxxxxxxxxx> --- (In reply to Roland Grunberg from comment #5) > Reviewed initially using 'fedora-review -b 978587 -P Java -m > fedora-rawhide-x86_64' > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > > It seems auto-{provides,requires} are not generated because of the > Bundle-ClassPath manifest attribute. It would be nice to change these to > Require-Bundle (I believe the listed libraries have proper manifests), and > make the libraries visible to others (through dropins) but I think the > current state of Bundle-ClassPath + symlinking is fine for now. > > [x]: Requires correct, justified where necessary. > - Package requires snakeyaml, and beust-jcommander at build/runtime but does > not explicitly list these in BuildRequires or as a requirement of the binary > rpm. Given that eclipse-testng will always depend on testng, which has its > own requires on these, I'm willing to accept this. > > I'd like to know your thoughts on the above, but after that I think I'll > have this approved. > > You're absolutely right, all the deps appear to have osgi metadata in both F20 and rawhide. In fact, doing it this way with Require-Bundle required I symlink additional deps (all transient deps of the deps listed in the BR/Rs) in order to fully resolve them -- the TestNG plug-in must not exercise the code paths that require these deps because I've been using this package in real life for a long time without issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review