[Bug 1081434] Review Request: ip2location - IP2location library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1081434



--- Comment #23 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Did you change the src.rpm since comment 20? That doesn't become clear, if you
never increase the Release value:

https://fedoraproject.org/wiki/Packaging:FrequentlyMadeMistakes

| Increase the "Release" tag every time you upload a new package to avoid
| confusion. The reviewer and other interested parties probably still have
| older versions of your SRPM lying around to check what has changed between
| the old and new packages; those get confused when the revision didn't change.

You also need to maintain a proper %changelog in the spec file that would tell
in which way you've changed the spec/package, especially if it fixed an issue.

In either case, if you visit the i686 build job output from comment 20,

  http://koji.fedoraproject.org/koji/taskinfo?taskID=6925071
   -> http://koji.fedoraproject.org/koji/taskinfo?taskID=6925074
    -> https://kojipkgs.fedoraproject.org//work/tasks/5074/6925074/build.log

you can see that it failed in %check. The src.rpm from comment 21 doesn't give
a hint whether that failure has been fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]