https://bugzilla.redhat.com/show_bug.cgi?id=705799 --- Comment #11 from David Dick <ddick@xxxxxxxx> --- Licensing is correct. MANDATORY: The following BRs must be added. Making the full set of dependent libraries explicit in the build requirements will help protect this module from unexpected breakages when the default set of libraries available in the fedora build environment changes (from actions in the perl-core or by the fedora build team) BR: perl(base) - lib/Parse/Evtx/BXmlNode/NameString.pm at line 2 BR: perl(Carp) - lib/Parse/Evtx/VariantType.pm at line 62 BR: perl(Digest::MD5) - scripts/evtxtemplates.pl at line 51 BR: perl(Encode) - lib/Parse/Evtx/BXmlNode/NameString.pm at line 5 BR: perl(Encode::Unicode) - lib/Parse/Evtx/BXmlNode/NameString.pm at line 6 BR: perl(Exporter) - lib/Parse/Evtx/Const.pm at line 8 BR: perl(Fcntl) - lib/Parse/Evtx.pm at line 12 BR: perl(Getopt::Long) - scripts/evtxtemplates.pl at line 52 BR: perl(IO::File) >= 1.14 - scripts/evtxtemplates.pl at line 50 BR: perl(Math::BigInt) - lib/Parse/Evtx.pm at line 11 BR: perl(strict) - scripts/evtxtemplates.pl at line 44 BR: perl(version) - lib/Parse/Evtx.pm at line 15 RunTime Requirement for perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) The following files need to be added to the dos2unix call lib/Parse/Evtx.pm lib/Parse/Evtx/VariantType.pm Interestingly enough, this was missed by rpmlint. COMMENTS This is a really old (and i'm not sure if it's still supported) package. Is it worth urging the author to at least contribute the module to CPAN? That way, if http://computer.forensikblog.de/ is taken off line, you've got somewhere to work with the source package? I usually add a Group of "Development/Libraries", but i understand this is optional for Fedora. Similarly i usually add the optional dist support in the Release tag? However, I'm happy to approve the package once the BR and RunTime requirements have been fixed and the dos2unix updates have been applied. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review