Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: bcel https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225610 ------- Additional Comments From mwringe@xxxxxxxxxx 2007-04-16 10:40 EST ------- (In reply to comment #7) > (In reply to comment #6) > > * The examples/Mini README probably shouldn't be marked as a %doc as it makes > > more sense to just leave it in the Mini directory. > Done > > * The demo package probably shouldn't install things to > > %{_datadir}/%{name}-%{version} but to %{_datadir}/%{name}-%{version}/demo > Fixed > > * It seems strange that the demo package doesn't have any documentation > > describing what the classes do and how to build them. But I guess the sources > > don't have this information either > Yeah, the upstream sources don't have any documentation either. > > * The build file for the demo package is the build.xml for the whole project. > > Perhaps this should be included in the demo package (or maybe a subset that > > would only build the demos?) > I've made the main package a Requires: for the demo package Yes, but the main pacakage doesn't include the build.xml (and shouldn't). The problem is that build scripts for the demos are in the main build.xml. So without the build.xml there is no way to know how to build and run the demos. But the build.xml also contains how to build the main package, so just including the build.xml as is will probably not be the best idea. I would suggest either creating a new demo build.xml file (it looks to just be a simple copy and paste from the original build.xml) or to remove the demo subpackage (it doesn't make sense to include a demo package that is just source files without documentation or build scripts). > > * The manual subpackage just has the license file in there, there should be more > > to the manual than this. maybe the manual only gets built if using maven? > The docs/* stuff are built but doesn't get included in the package, I copied the > LICENCE.txt to %{_docdir}/%{name}-%{version}, so that the docs/* stays in the > package. > > > New spec file and srpm at the same location. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review